bug in passive host check handling

This forum is intended for the discussion of Nagios Core development. Feature requests, patches, bug fixes, and all types of development-related discussions are welcome!

NOTE: The SourceForge.net nagios-devel mailing list has been deprecated in favor of this forum in order to expedite support and provide additional features not available on the old mailing list.

bug in passive host check handling

Postby eponymousalias » Mon Aug 26, 2019 2:08 pm

In Nagios 4.4.4 base/commands.c, we have the following code fragments:
Code: Select all
   2358 int process_passive_service_check(time_t check_time, char *host_name, char *svc_description, int return_code, char *output) {
   2359         check_result cr;
   2360         host *temp_host = NULL;
   2361         service *temp_service = NULL;
   2362         struct timeval tv;
   2363
   2364         /* skip this service check result if we aren't accepting passive service checks */
   2365         if(accept_passive_service_checks == FALSE)
   2366                 return ERROR;

   2470 int process_passive_host_check(time_t check_time, char *host_name, int return_code, char *output) {
   2471         check_result cr;
   2472         host *temp_host = NULL;
   2473         struct timeval tv;
   2474
   2475         /* skip this host check result if we aren't accepting passive host checks */
   2476         if(accept_passive_service_checks == FALSE)
   2477                 return ERROR;

Clearly, in that second fragment, accept_passive_service_checks should be accept_passive_host_checks instead.

And to answer your presumptive question, this is as far as I'm going to take this bug report.
eponymousalias
 
Posts: 14
Joined: Mon Mar 07, 2016 5:38 am

Re: bug in passive host check handling

Postby mbellerue » Mon Aug 26, 2019 2:40 pm

Very awesome! Thank you for pointing this out! We'll get it handled.
As of May 25th, 2018, all communications with Nagios Enterprises and its employees are covered under our new Privacy Policy.

Be sure to check out our Knowledgebase for helpful articles and solutions!
User avatar
mbellerue
 
Posts: 608
Joined: Fri Jul 12, 2019 11:10 am


Return to Nagios Core Development

Who is online

Users browsing this forum: MSN [Bot] and 1 guest