Tracking Patch Submissions

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
jrz
Posts: 2
Joined: Tue May 05, 2015 7:40 am

Tracking Patch Submissions

Post by jrz »

I have a question about how patch submissions are handled for the core... if we submit a patch, is it automatically assigned a tracking number so that we can determine when it has been delivered in the next Core patch? My concern is that if we submit some patches, then have a new Core release available, we'll have a mess trying to correlate our changes with the new release.
ssax
Dreams In Code
Posts: 7682
Joined: Wed Feb 11, 2015 12:54 pm

Re: Tracking Patch Submissions

Post by ssax »

Are you asking about doing it through tracker or on the GitHub page?

https://github.com/NagiosEnterprises/nagioscore
jrz
Posts: 2
Joined: Tue May 05, 2015 7:40 am

Re: Tracking Patch Submissions

Post by jrz »

I thought patches were submitted to this forum, usually using diff to describe the changes needed... Let me back up a step. If we're using Nagios and have a fix we've made in the core and want to submit it to the community, what process should we follow? What is the process the submissions follow so that we can determine if it's been accepted and incorporated?
jdalrymple
Skynet Drone
Posts: 2620
Joined: Wed Feb 11, 2015 1:56 pm

Re: Tracking Patch Submissions

Post by jdalrymple »

I'd say you're half right:

From readme.md

Code: Select all

+Contributing
+------------
+The Nagios source code is hosted on GitHub:
+https://github.com/NagiosEnterprises/nagioscore
+
+Do you have an idea or feature request to make Nagios better? Join or
+start a discussion on the
+http://support.nagios.com/forum/viewforum.php?f=34[Nagios Core Development forum].
+Bugs can be reported at http://tracker.nagios.org, or by
+https://github.com/NagiosEnterprises/nagioscore/issues/new[opening an
+issue on GitHub]. If you have identified a security related issue in
+Nagios, please contact security@nagios.com.
+
+Patches and GitHub pull requests are welcome. Pull requests on GitHub
+link commits in version control to review and discussion of the
+changes, helping to show how and why changes were made, in addition to
+who was involved.
+
+Created by Ethan Galstad, the success of Nagios has been due to the
+fantastic community members that support it and provide bug reports,
+patches, and great ideas. See the
+https://raw.githubusercontent.com/NagiosEnterprises/nagioscore/master/THANKS[THANKS file]
+for some of the many who have contributed since 1999.
If you already have a patch I'd suggest going straight to the source (pun intended) and issue a pull request.
Locked