check_disk and NFS timeouts

This forum is intended for the discussion of Nagios plugin development. Feature requests, patches, bug fixes, and all types of development-related discussions are welcome!

NOTE: The SourceForge.net nagiosplug-devel mailing list has been deprecated in favor of this forum in order to expedite support and provide additional features not available on the old mailing list.

check_disk and NFS timeouts

Postby handy » Wed Apr 09, 2014 8:48 pm

Hi,


When will the official Nagios plugins release channel include the patch to properly timeout when NFS (for example, other remote filesystems may also be applicable) is unavailable?

There was a patch I found, some time ago. It's this one:

https://nagios-plugins.org/archive/deve ... 09137.html

This seems like a dead obvious, useful and probably mandatory change.

Without it, we have (as do no doubt many others out there) plugin processes climb through the roof and push the load avg. of a machine up if there's any sort of NFS/network outage. This must break a presumably fundamental law of "thy monitoring system should not impact thy machine"

My apologies if it is already in, or if this is an FAQ but I've reviewed the 2.0 Change Log and can see no mention of it.
handy
 
Posts: 3
Joined: Wed Apr 09, 2014 8:32 pm

Re: check_disk and NFS timeouts

Postby sreinhardt » Thu Apr 10, 2014 10:36 am

I can't say that we were aware of this being an issue, but can definitely understand where it should be resolved. You certainly do not have to, but could you make an issue on the github account so that you may follow as we patch it? https://github.com/nagios-plugins/nagios-plugins/issues
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
sreinhardt
-fno-stack-protector
 
Posts: 4366
Joined: Mon Nov 19, 2012 12:10 pm

Re: check_disk and NFS timeouts

Postby handy » Thu Apr 10, 2014 1:38 pm

Hi,


Thanks for the quick reply.

I'm happy to create an issue, as you request - but did you know there was a previous issue there during December 2013? It used to be here:

https://github.com/nagios-plugins/nagio ... issues/867

And now it's gone. There appears to have been a "shake up" (for lack of a better word) of the issue list, which is no doubt to do with the move to a new major release (2.0) ?

Although you can't obviously view that issue any more, you can find referring info:

http://comments.gmane.org/gmane.network ... devel/8186

waja | 1 Oct 09:01 2013
[nagios-plugins] check_disk: no longer hangs on hanging filesystems (#1186)

Just turning attached patch of github issue #867 into a push request.
You can merge this Pull Request by running
git pull https://github.com/waja/nagios-plugins github867

Or view, comment on, or merge it at:

https://github.com/nagios-plugins/nagio ... /pull/1186
Commit Summary

check_disk: no longer hangs on hanging filesystems

File Changes

M configure.in (12)
M plugins/Makefile.am (2)
M plugins/check_disk.c (40)

Patch Links:

https://github.com/nagios-plugins/nagio ... 1186.patch
https://github.com/nagios-plugins/nagio ... /1186.diff




What happened?
handy
 
Posts: 3
Joined: Wed Apr 09, 2014 8:32 pm

Re: check_disk and NFS timeouts

Postby sreinhardt » Fri Apr 11, 2014 9:51 am

Perfect, I will take a look at the patches, make sure it applies without issues and get it in for 2.0.1 which should be out soon. The change in issues on github is actually due to the monitoring-plugins and nagios-plugins separation. The issue is available via their github pages.
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
sreinhardt
-fno-stack-protector
 
Posts: 4366
Joined: Mon Nov 19, 2012 12:10 pm

Re: check_disk and NFS timeouts

Postby handy » Sun Apr 13, 2014 4:22 am

Thanks heaps, that sounds great.
handy
 
Posts: 3
Joined: Wed Apr 09, 2014 8:32 pm

Re: check_disk and NFS timeouts

Postby sreinhardt » Mon Apr 14, 2014 3:56 pm

You're welcome! I'll post back here or edit this once we get it in!
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
sreinhardt
-fno-stack-protector
 
Posts: 4366
Joined: Mon Nov 19, 2012 12:10 pm


Return to Nagios Plugin Development

Who is online

Users browsing this forum: No registered users and 4 guests