Re: [Nagios-devel] fix delete_all_host_comment,

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] fix delete_all_host_comment,

Post by Guest »

On 10/06/2011 01:07 PM, Dorian Guillois wrote:
> Hi everybody,
>
> Attached patches fix some bugs on functions delete_all_host_comment,
> unschedule_downtime and
> delete_downtime_by_hostname_service_description_start_time_comment. In
> this 3 functions a pointer on a deleted object is used.
>

Good catch.

There's a bug in your patches though. In all cases you point next_item to
this_item->next, but then iterate it using next_item->next, meaning you'll
skip every other item.

If you resend corrected patches I'll apply them. Thanks

--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: ae@op5.se
Locked