Re: [Nagios-devel] [PATCH 2/4] qh: Fall for peer pressure from

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] [PATCH 2/4] qh: Fall for peer pressure from

Post by Guest »

On 11/28/2012 03:37 PM, robin.sonefors@op5.com wrote:
>> First off, the nerd channel list must be generated dynamically. We
>> have them in a handy array, so we might as well print them all
>> while we're at it. If we make it possible to provide a description
>> string when creating the channel we can print that too and the help
>> API for the nerd channel is pretty much complete.
>
> Right. Sure. I guess I was just wary of API modifications, but no problem to do
> so. Split that into it's own patch.
>

Well, 4.0 isn't released yet, so minor mods are ok.

>> Why not just 'help'? That way people can do what's natural
>> with text interfaces and try "@nerd help" and they would still get the
>> same response, whereas typing "@nerd --help" into an interactive text
>> listener seems less intuitive.
>
> My reasoning was to have something obscure enough that it would be unlikely to
> clash with other commands. I realize now that was pretty crappy reasoning -
> what else would be called "help"?
>
> Note that this feedback affects the first patch in my last patch series, so
> I've changed that patch, rather than change it in a new patch on top of that
> one.
>
> In other words, these three patches replace the first two patches in the old
> series, but the last two in the last series still applies. I'll do things
> differently if you tell me how.
>

I've revamped them a bit myself. I should almost certainly have told you,
since you sit about three feet away from me, but I forgot. Mea culpa. The
nerd_channel->description stuff is something I haven't gotten round to
yet though, so I'll take those. Hold off on new stuff in this area until
I've shipped the modified patches upstream.

--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: ae@op5.se
Locked