Page 1 of 1

tac.cgi header

Posted: Fri Feb 09, 2018 7:37 am
by tpensel
Hi,

i am trying get rid of the header of the tac.cgi. &noheader does not work like in status.cgi.

Thanks in advance

Tom

Re: tac.cgi header

Posted: Fri Feb 09, 2018 12:57 pm
by mcapra
Can you show the exact url you used? tac.c works almost exactly the same as status.c in this regard.

It's worth mentioning that, for GET variables in a URL, & always needs to follow ?. If your URL only has one GET variable, then you should do something like ?noheader instead of &noheader.

Re: tac.cgi header

Posted: Fri Feb 09, 2018 2:06 pm
by kyang
Thanks mcapra!

tpensel, do you by chance have a ticket opened with us? This is almost the exact same question.

Re: tac.cgi header

Posted: Sat Feb 10, 2018 11:41 am
by tpensel
Hi everybody,

I did Not Open a Ticket at Nagios. Yes of course i changed &noheader to ?noheader cause i pass only one parameter. But did not work ether

Re: tac.cgi header

Posted: Mon Feb 12, 2018 11:06 am
by mcapra
Apologies if the ? and & differences seem trivial, but it's important to qualify any potential bugs as thoroughly as possible.

That said, I seem to be encountering the same problems. That is because this section of the tactical overview that I've highlighted in red:
2018_02_12_09_50_14_Nagios_Tactical_Monitoring_Overview.png
Isn't actually part of the "header". I put "header" in quotes because, well, very similar chunks of a page (like status.cgi) disappear with the noheader parameter.

That aside, this section drawn with the display_tac_overview function. Which runs regardless of the noheader option.

That said, it is actually impossible for the header to be drawn on this page because the display_header boolean is initialized to FALSE and had no condition in which it is set to TRUE. In a true Scooby-Doo moment, here is what the *actual* header for tac.cgi looks like (highlighted in green):
2018_02_12_10_00_18_Nagios_Tactical_Monitoring_Overview.png
Which does respect the noheader option.

That said, perhaps display_tac_overview shouldn't have a call to display_info_table in it to be consistent with other Nagios Core pages and the behavior of noheader. I dunno. I've filed a GitHub issue with my findings:
https://github.com/NagiosEnterprises/na ... issues/481

Re: tac.cgi header

Posted: Mon Feb 12, 2018 12:18 pm
by kyang
Thanks @mcapra!