Install script MacOSX NCPA 1.7.2 has a problem creating user

[fermatcapital]

Note that the creation of username is only done if the nagcmd group doesn't exist. This is ok, however, the env variable username is not defined.

Is this a bug?

Code: Select all

#!/bin/sh

set -e

pushd /Volumes/NCPA-*

groupname=nagcmd
homedir=/usr/local/ncpa

# Create the user account
if ! dscl . -read /Groups/${groupname} > /dev/null;
then
    dscl . -create /Users/${username}
    dscl . -create /Users/${username} UserShell /usr/bin/false
    dscl . -create /Users/${username} UniqueID 569      
    dscl . -create /Users/${username} RealName "${username}"
    dscl . -create /Users/${username} PrimaryGroupID 20 
    dscl . -create /Users/${username} Password "*"        
    dscl . -create /Users/${username} NFSHomeDirectory ${homedir}
else
    echo 'User already exists, skipping!'
fi

if ! dscl . -read /Groups/${groupname} > /dev/null; 
then
    # Create the group
    dscl . -create /Groups/${groupname}
    dscl . -create /Groups/${groupname} RecordName "_${groupname} ${username}"
    dscl . -create /Groups/${groupname} PrimaryGroupID 20 
    dscl . -create /Groups/${groupname} RealName "${groupname}"
    dscl . -create /Groups/${groupname} Password "*"
else
    echo 'Group already exists, skipping!'
fi

cp ncpa/build_resources/ncpa_listener.plist /Library/LaunchDaemons/com.nagios.ncpa.listener.plist
cp ncpa/build_resources/ncpa_passive.plist /Library/LaunchDaemons/com.nagios.ncpa.passive.plist

mkdir -p /usr/local/ncpa
cp -rf ncpa/* /usr/local/ncpa/
chmod -R 775 /usr/local/ncpa
chown -R nagios:nagcmd /usr/local/ncpa

launchctl load /Library/LaunchDaemons/com.nagios.ncpa.listener.plist
launchctl load /Library/LaunchDaemons/com.nagios.ncpa.passive.plist

launchctl start com.nagios.ncpa.passive

[ssax]

Looks like a bug to me, thanks for reporting it!

I submitted a new issue at the GitHub for NCPA:
https://github.com/NagiosEnterprises/ncpa/issues/155