This is a multi-part message in MIME format.
--------------050405070809080606000800
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Jochen Bern wrote:
> On 08/31/2010 04:19 PM, Jochen Bern wrote:
>> The whitespace detection is still not quite finished because I hit a
>> snag in the existing code, namely, in cgi/cgiutils.c::url_encode() :
> In the process of touching up 3.2.3 (CVS HEAD as of today) to include my
> local patches, I had a look at the references to url_encode(); I don't
> think that any reference *other* than the Command Expansion will ever
> feed control characters into it. Thus, I fixed the "is a space"
> comparison and removed the workaround in CE.
>
> Also included in the attached patch:
> -- corrected typo in "entry" hyperlink (thanks to Alexey Dvoryanchikov,
> via Icinga / Michael Friedrich)
Just to correct this - I only notified you about that, patch origin is
over here: http://tracker.nagios.org/view.php?id=169
I've tested and applied it in Icinga GIT, so it could run straight up
into Nagios HEAD too.
> -- added hyperlinks to the CE of (active) check commands and event
> handlers into the extinfo.cgi pages of hosts and services
>
> -------
>
> While I'm writing: I intend to streamline some more patches so that they
> can be included into the authoritative source, but need to be activated
> by explicit request. I'm thinking along the lines of
> CFLAGS="-DFEATURE_XY"
> and optionally adding support into configure, pretty much like
> --with-feature-xy
> Or is there an established other syntax/format/... to do this?
What kind of patches/enhancements and can they be made optional by a
config option instead?
Kind regards,
Michael
> Kind regards,
> J. Bern
>
>
> ------------------------------------------------------------------------------
> The Next 800 Companies to Lead America's Growth: New Video Whitepaper
> David G. Thomson, author of the best-selling book "Blueprint to a
> Billion" shares his insights and actions to help propel your
> business during the next growth cycle. Listen Now!
> http://p.sf.net/sfu/SAP-dev2dev
>
>
> _______________________________________________
> Nagios-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/lis ... gios-devel
--
DI (FH) Michael Friedrich
Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria
email: [email protected]
phone: +43 1 4277 14359
fax: +43 1 4277 14279
web: http://www.univie.ac.at/zid
Icinga Core& IDOUtils Developer
http://www.icinga.org
--------------050405070809080606000800
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Jochen Bern wrote:
On 08/31/2010 04:19 PM, Jochen Bern wrote:
The whitespace detection is still not quite finished because I hit a
snag in the existing code, namely, in cgi/cgiutils.c::url_encode() :
In the process of touching up 3.2.3 (CVS HEAD as of today) to include my
local patches, I had a look at the references to url_encode(); I don't
think that any reference *other* than the Command Expansion will ever
feed control characters into it. Thus, I fixed the "is a space"
comparison and removed the workaround in CE.
Also included in the attached patch:
-- corrected typo in "entry" hyperlink (thanks to Alexey Dvoryanchikov,
via Icinga / Michael Friedrich)
Just to correct this - I only notified you about that, patch origin
is over here: http://tracker.nagios.org/view.php?id=169
I've tested and applied it in Icinga GIT, so it could run straight
up into Nagios HE
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]