----- Original Message -----
>=20
>=20
> ----- Original Message -----
> > On 06/22/2012 08:57 PM, Ricardo Maraschini wrote:
> > > hello,
> > >=20
> > > i've removed two unused variables on found_macro_x() function.
> > > Compiler errors:
> > >=20
> > > ../common/macros.c: In function =E2=80=98process_macros_r=E2=80=99:
> > > ../common/macros.c:133:6: warning: variable =E2=80=98found_macro_x=E2=
=80=99 set
> > > but
> > > not used [-Wunused-but-set-variable]
> > > ../common/macros.c:128:6: warning: variable =E2=80=98x=E2=80=99 set b=
ut not used
> > > [-Wunused-but-set-variable]
> > >=20
> > >=20
> > > OK? Comments?
> > >=20
> >=20
> > Test this with macro resolution debugging turned on. I just
> > reverted a patch that did this change (and a bunch of other
> > -Wunused-but-set-variable), and removing the unused ones
> > actually broke macro resolution for the core.
>=20
> Just for curiosity, the patch you've reverted had the same logic as
> mine regarding strcmp()?
>=20
Oh, now I see. I've made a diff between revisions 1853 and 1951 for common/=
macros.c and it clearly pointed me to a bug. That patch(applied to create r=
evision 1951) is different of mine, regarding strcmp() use. Really, that pa=
tch is supposed to explode everything, you gonna see it if you look closely=
BTW, I've tested the patch i've sent to you and i had no problems regarding=
macro resolutions so far.
[1340638282.241842] [2048.1] [pid=3D20560] **** BEGIN MACRO PROCESSING ****=
*******
[1340638282.241848] [2048.1] [pid=3D20560] Processing: '$USER1$/check_ssh -=
t 60 -p 54978 $HOSTADDRESS$'
[1340638282.241910] [2048.1] [pid=3D20560] Done. Final output: '/usr/loc=
al/opmon/libexec/check_ssh -t 60 -p 54978 192.168.8.1'
[1340638282.251285] [2048.1] [pid=3D20560] **** BEGIN MACRO PROCESSING ****=
*******
[1340638282.269438] [2048.1] [pid=3D20560] Processing: '$USER1$/check_nrpe =
-H $HOSTADDRESS$ -p 5666 -t 60 -u -c $ARG1$ -a $ARG2$'
[1340638282.269463] [2048.1] [pid=3D20560] Done. Final output: '/usr/loc=
al/opmon/libexec/check_nrpe -H 127.0.0.1 -p 5666 -t 60 -u -c otrs_tickets_e=
ntrada_user -a 0 0 3'
[1340638282.277821] [2048.1] [pid=3D20560] **** BEGIN MACRO PROCESSING ****=
*******
-rm
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]