Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
All,
I have a strange scenario on a Solaris 10 server using ZFS. The server has several ZFS Pools configured, but only one of them is larger than 1TB. We've been monitoring this server for about a week with out issue. This morning check_disk reports the 2TB filesystem as 0% available and is throwing false alarms. In df, the filesystem is only 39% used.
Seems like some kind of math problem, when we have 2.14^12 bytes capacity, with 8.26^11 bytes used. My desktop calculator reports that math to be 38.5%
Interesting, this looks like the performance data is outputted correctly, but the standard message is not. I will take a look into this tonight where I have several large disks to test against. If it does turn out to be a bug, I may ask that you submit a bug post on the github.com/nagios-plugins page, however I would like to do some testing first.
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
sreinhardt wrote:Interesting, this looks like the performance data is outputted correctly, but the standard message is not. I will take a look into this tonight where I have several large disks to test against. If it does turn out to be a bug, I may ask that you submit a bug post on the github.com/nagios-plugins page, however I would like to do some testing first.
OH, 1.4.2, I think this is already patched. I created a virtual 4TB disk last night and ran tests against, was well as a physical 2TB disk and did not have issues with the present 1.5 code. I would highly suggest updating. Myself and abrist have made many improvements in the maint branch in the last few days, as well as the master branch should contain the fix you are looking for presently. http://github.com/nagios-plugins
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
- which seems to be the latest version of nagios_plugins in all of the package trees available through OpenCSW. Can you tell me what version this issue would have been resolved in? It seems like the check_disk.c code for 1.4.16 on github hasn't been touched in ~3 years, the OpenCSW package was built in July of 2012.
It looks like this fix for blocksize differences might be a possible, but it seems to be tagged in both 1.5 and 1.4.16. We are running with several Zpools that have a mix of blocksizes. The ZFS default is 128K, and the filesystem in this issue has that size, but there are other ZFS filesystems on the server which have 8K blocksizes for Oracle DB files.
My mistake on the version, now I'm not sure where I got 1.4.2 from... Anyway, the news file states that it should have been resolved with the changes to plugins/check_disk.c and lib/disk_utils.c with 1.4.16, which should indicate that you have it. Apparently this does not seem to be the case. I will have to setup a opensolaris or opencsw system with some virtual disks in zpools to test it tonight. Also just a note, any changes relevant to this, likely would be in disk_utils.c not check_disk.c, as the former holds most of the functions for doing the calculations we need.(at least from the brief look I gave it)
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
sreinhardt wrote:My mistake on the version, now I'm not sure where I got 1.4.2 from... Anyway, the news file states that it should have been resolved with the changes to plugins/check_disk.c and lib/disk_utils.c with 1.4.16, which should indicate that you have it. Apparently this does not seem to be the case. I will have to setup a opensolaris or opencsw system with some virtual disks in zpools to test it tonight. Also just a note, any changes relevant to this, likely would be in disk_utils.c not check_disk.c, as the former holds most of the functions for doing the calculations we need.(at least from the brief look I gave it)
Thanks, and thanks for the correction. It's only been twenty years since I studied Kernighan and Ritche in college Please forgive me.
HAHA, no worries, good old K&R still nothing quite like it.
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.
Yes I did have a chance to test some aspects of it, got a zfs pool created with ~3tb space, but was unable to replicate the same issue. I was testing on linux not opencsw though, and am thinking that must be the difference. Once I finish getting that setup I will post back again, feel free to bug me all you want, its a good reminder.
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.