Re: [Nagios-devel] Bug and (loosely related) patch: Nagios 3.2.1
Posted: Tue Aug 31, 2010 1:19 pm
This is a multi-part message in MIME format.
--------------020801020804010803060501
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 08/29/2010 06:24 PM, Jochen Bern wrote:
> Sorry for the extra work, but there'll be at least one more update - I
> used strtok() where I *should* have used my_strsep() from the cgiutils
Next attempt ...
-- Replaced the offending strtok() with some local code ...
-- ... which also handles the backslash escapes of Nagios 3.x.
-- Tells "(undefined)" and "(empty)" $ARGn$s apart.
-- Warns of $ARGn$s with leading or trailing whitespace ...
-- ... and additionally puts them into "..." to make
sure that there'll be *something* displayed with the $ARGn$'s color
(see the "unused: $ARG5$=3D" line in the screenshot for an example).
-- Changed a boatload of "printf(...,some_string);" to
"printf(...,html_encode(some_string,FALSE));".
The whitespace detection is still not quite finished because I hit a
snag in the existing code, namely, in cgi/cgiutils.c::url_encode() :
> /* spaces are pluses */
> else if((char)input[x] str[y]=3D'+';
> y++;
> }
>=20
> /* anything else gets represented by its hex value */
> else{
Note the "
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP =3D D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C2=
7
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Gesch=E4ftsf=FChrer Metin Dogan, Oliver Mic=
hel
--------------020801020804010803060501
Content-Type: image/png;
name="CommandExpansion4.png"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="CommandExpansion4.png"
iVBORw0KGgoAAAANSUhEUgAAA7UAAAFyCAIAAAClSWpHAAAACXBIWXMAAA8SAAAPEgEhm/Iz
AAAgAElEQVR4nOzdeVyM2/8A8M80zUybbpqotFqSLcvNVklJpUQhO99Qsmdfv33d373fu6AM
Zc9X165uLhGVJbuQhCsiKS0qYYT2/ffH4ekxzzPTGCru/bxfXl4z5znPcz7n2ebM6cx5OHV1
dYAQQgghhBACAACl5g4AIYQQQgihrwi2jxFCCCGEEKqH7WOEEEIIIYTqYfsYIYQQQgihetg+
RgghhBBCqB62jxFC36SXL1/OnDlTT09PIBD07Nnzzz//bO6IPg2Hw+FwONLSJTR9eExfTyQI
IdTYODi/G0Lom1NUVNSnT5/U1FR6YlhY2Pjx45srpE9F2prMOzBrGxRv1Agh1JSw/xgh9O0J
CAhITU21srJKT09//fq1q6srAPz3v/+lMvz555+dO3fm8/ldunQ5evQolU46QTds2KCjo9Oh
Q4cHDx7MnTtXIBB06NDh6tWr8ud5/PjxoEGD1NTUBAKBpaXlzZs36etGRER07txZIBD07dv3
3r17VOmbN2/W1dXV1dXdsmWL7ArWfQwAkpKSlJWVraysyNI+ffrweLw7d+5QhW7atElPT09H
R2fr1q3UdhSIMzk5ecCAASoqKurq6o6OjpmZmfRV5NzD0vYAQgh9G+oQQuhb061bNwC4desW
eZuammpnZ3fhwgXy9vTp0/SWHIfDOX36NFkkcQPs3LkzldPCwkL+PJaWlhJ5WNcFgD59+pBF
e/fulecOLOPOvGDBAgCIjIwkm/L395dWaHh4uMJxdu3alZ7ev39/ZmDy72H6lhFC6FuB7WOE
0LdHVVUVACoqKliX2tnZAcD06dMLCwu9vb0BwNbWliwiLbadO3fevn2bvN62bVtiYiIAKCsr
y5+HqK2tTUpKAgAej0df18nJ6c2bNwcOHAAAgUBAFvXq1QsAZsyY8e7du+nTp8tuH0sgi4qK
igwNDTt37mxgYNClSxeq+iTP9OnT3759S+rbu3dvheNUUVEBgLt377IGJuceZt0yQgh9K3D8
MULo2yMQCCorK8vLywUCAXOphoZGSUlJYWGhlpZWYWGhtra2qqpqaWkpfBjdW1xcrKqqyuVy
AaCoqEhNTY28JvdDefIAwKVLl6Kios6ePZucnCyx7uPHj83MzCoqKkhbkyxSUVGpqKh4+vSp
qalpWlpax44d4dPHHx89etTT0xMArly5MmDAAPoqZMtPnjwxMzNT
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
--------------020801020804010803060501
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 08/29/2010 06:24 PM, Jochen Bern wrote:
> Sorry for the extra work, but there'll be at least one more update - I
> used strtok() where I *should* have used my_strsep() from the cgiutils
Next attempt ...
-- Replaced the offending strtok() with some local code ...
-- ... which also handles the backslash escapes of Nagios 3.x.
-- Tells "(undefined)" and "(empty)" $ARGn$s apart.
-- Warns of $ARGn$s with leading or trailing whitespace ...
-- ... and additionally puts them into "..." to make
sure that there'll be *something* displayed with the $ARGn$'s color
(see the "unused: $ARG5$=3D" line in the screenshot for an example).
-- Changed a boatload of "printf(...,some_string);" to
"printf(...,html_encode(some_string,FALSE));".
The whitespace detection is still not quite finished because I hit a
snag in the existing code, namely, in cgi/cgiutils.c::url_encode() :
> /* spaces are pluses */
> else if((char)input[x] str[y]=3D'+';
> y++;
> }
>=20
> /* anything else gets represented by its hex value */
> else{
Note the "
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP =3D D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C2=
7
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Gesch=E4ftsf=FChrer Metin Dogan, Oliver Mic=
hel
--------------020801020804010803060501
Content-Type: image/png;
name="CommandExpansion4.png"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="CommandExpansion4.png"
iVBORw0KGgoAAAANSUhEUgAAA7UAAAFyCAIAAAClSWpHAAAACXBIWXMAAA8SAAAPEgEhm/Iz
AAAgAElEQVR4nOzdeVyM2/8A8M80zUybbpqotFqSLcvNVklJpUQhO99Qsmdfv33d373fu6AM
Zc9X165uLhGVJbuQhCsiKS0qYYT2/ffH4ekxzzPTGCru/bxfXl4z5znPcz7n2ebM6cx5OHV1
dYAQQgghhBACAACl5g4AIYQQQgihrwi2jxFCCCGEEKqH7WOEEEIIIYTqYfsYIYQQQgihetg+
RgghhBBCqB62jxFC36SXL1/OnDlTT09PIBD07Nnzzz//bO6IPg2Hw+FwONLSJTR9eExfTyQI
IdTYODi/G0Lom1NUVNSnT5/U1FR6YlhY2Pjx45srpE9F2prMOzBrGxRv1Agh1JSw/xgh9O0J
CAhITU21srJKT09//fq1q6srAPz3v/+lMvz555+dO3fm8/ldunQ5evQolU46QTds2KCjo9Oh
Q4cHDx7MnTtXIBB06NDh6tWr8ud5/PjxoEGD1NTUBAKBpaXlzZs36etGRER07txZIBD07dv3
3r17VOmbN2/W1dXV1dXdsmWL7ArWfQwAkpKSlJWVraysyNI+ffrweLw7d+5QhW7atElPT09H
R2fr1q3UdhSIMzk5ecCAASoqKurq6o6OjpmZmfRV5NzD0vYAQgh9G+oQQuhb061bNwC4desW
eZuammpnZ3fhwgXy9vTp0/SWHIfDOX36NFkkcQPs3LkzldPCwkL+PJaWlhJ5WNcFgD59+pBF
e/fulecOLOPOvGDBAgCIjIwkm/L395dWaHh4uMJxdu3alZ7ev39/ZmDy72H6lhFC6FuB7WOE
0LdHVVUVACoqKliX2tnZAcD06dMLCwu9vb0BwNbWliwiLbadO3fevn2bvN62bVtiYiIAKCsr
y5+HqK2tTUpKAgAej0df18nJ6c2bNwcOHAAAgUBAFvXq1QsAZsyY8e7du+nTp8tuH0sgi4qK
igwNDTt37mxgYNClSxeq+iTP9OnT3759S+rbu3dvheNUUVEBgLt377IGJuceZt0yQgh9K3D8
MULo2yMQCCorK8vLywUCAXOphoZGSUlJYWGhlpZWYWGhtra2qqpqaWkpfBjdW1xcrKqqyuVy
AaCoqEhNTY28JvdDefIAwKVLl6Kios6ePZucnCyx7uPHj83MzCoqKkhbkyxSUVGpqKh4+vSp
qalpWlpax44d4dPHHx89etTT0xMArly5MmDAAPoqZMtPnjwxMzNT
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]