Re: [Nagios-devel] [PATCH] circular dependency check speedup
Posted: Thu Dec 16, 2010 5:52 pm
On 12/16/2010 03:23 AM, Andreas Ericsson wrote:
> I'd appreciate if you could send new threads as new messages
> instead of as replies to current threads. Especially when you're
> sending patches. If I hadn't been interested in the topic listed
> in this thread, I'd have missed this patch and it had been dropped
> on the floor (unless Ton had applied it, in which case I would
> have reverted parts of it quite promptly).
Sorry, I had not realized an old thread reference would be
preserved in the email headers.
> I've done some organoleptic analysis of the patch (looked at it).
> Analysis included below.
Your analysis is based on your general experience, but most of it
doesn't apply to this patch. A lot of good engineering work went
into it, with each improvement based on before/after profiling, to
identify the hot spots and prove the significant performance gains.
I'll respond in more detail in a few days.
Glenn
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> I'd appreciate if you could send new threads as new messages
> instead of as replies to current threads. Especially when you're
> sending patches. If I hadn't been interested in the topic listed
> in this thread, I'd have missed this patch and it had been dropped
> on the floor (unless Ton had applied it, in which case I would
> have reverted parts of it quite promptly).
Sorry, I had not realized an old thread reference would be
preserved in the email headers.
> I've done some organoleptic analysis of the patch (looked at it).
> Analysis included below.
Your analysis is based on your general experience, but most of it
doesn't apply to this patch. A lot of good engineering work went
into it, with each improvement based on before/after profiling, to
identify the hot spots and prove the significant performance gains.
I'll respond in more detail in a few days.
Glenn
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]