Re: [Nagios-devel] Nagios - Attribute based authorization
Posted: Mon Nov 15, 2010 4:53 pm
This is a multi-part message in MIME format.
--------------050608040507020701050101
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
2010-11-15 17:26 keltez=C3=A9ssel, V=C3=A1g=C3=B3 Tibor =C3=ADrta:
> 2010-11-03 11:43 keltez=C3=A9ssel, Andreas Ericsson =C3=ADrta:
>> On 11/02/2010 07:23 PM, V=C3=A1g=C3=B3 Tibor wrote:
>>> Hi Andreas,
>>>
>>> ok, thanks for your information.
>>>
>>
>> I've had a peak. The patch is extremely weirdly indented, making
>> it hard to follow. Spaces are mixed with tabs and the tabsetting
>> seems to be non-standard.
>>
>> Re-indent your parts of the code to either match the current
>> coding standards or to match those used in the linux kernel
>> project and re-submit a new diff. Then I'll have a look again.
>
> Dear Andreas,
>
> here is the reformatted nicely tabbed diff file.
>
> In this patch I've changed the authorization filename from
> "authorization.cfg" to "cgiauth.cfg" too.
Hi,
Sorry, but NIIFI specific attributes was remain in the patch, so I=20
resend the stripped and more detailed version of patch.
Thanks,
Tibor
--------------050608040507020701050101
Content-Type: text/plain;
name="authorization.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="authorization.patch"
SW5kZXg6IG5hZ2lvcy0zLjIuMS9jb25maWd1cmUKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbmFnaW9z
LTMuMi4xL2NvbmZpZ3VyZQkocmV2aXNpb24gMTc2KQorKysgbmFnaW9zLTMuMi4xL2NvbmZp
Z3VyZQkocmV2aXNpb24gMjczKQpAQCAtOTE4Niw2ICs5MTg2LDcgQEAKIAogcGVybCBzdWJz
dCBzYW1wbGUtY29uZmlnL25hZ2lvcy5jZmcKIHBlcmwgc3Vic3Qgc2FtcGxlLWNvbmZpZy9j
Z2kuY2ZnCitwZXJsIHN1YnN0IHNhbXBsZS1jb25maWcvY2dpYXV0aC5jZmcKIHBlcmwgc3Vi
c3Qgc2FtcGxlLWNvbmZpZy9yZXNvdXJjZS5jZmcKIHBlcmwgc3Vic3Qgc2FtcGxlLWNvbmZp
Zy9odHRwZC5jb25mCiBwZXJsIHN1YnN0IHNhbXBsZS1jb25maWcvbXJ0Zy5jZmcKSW5kZXg6
IG5hZ2lvcy0zLjIuMS9NYWtlZmlsZS5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBuYWdpb3MtMy4y
LjEvTWFrZWZpbGUuaW4JKHJldmlzaW9uIDE3NikKKysrIG5hZ2lvcy0zLjIuMS9NYWtlZmls
ZS5pbgkocmV2aXNpb24gMjczKQpAQCAtMjQzLDYgKzI0Myw3IEBACiBpbnN0YWxsLWNvbmZp
ZzoKIAkkKElOU1RBTEwpIC1tIDc3NSAkKElOU1RBTExfT1BUUykgLWQgJChERVNURElSKSQo
Q0ZHRElSKQogCSQoSU5TVEFMTCkgLW0gNzc1ICQoSU5TVEFMTF9PUFRTKSAtZCAkKERFU1RE
SVIpJChDRkdESVIpL29iamVjdHMKKwkkKElOU1RBTEwpIC1iIC1tIDY2NCAkKElOU1RBTExf
T1BUUykgc2FtcGxlLWNvbmZpZy9jZ2lhdXRoLmNmZyAkKERFU1RESVIpJChDRkdESVIpL2Nn
aWF1dGguY2ZnCiAJJChJTlNUQUxMKSAtYiAtbSA2NjQgJChJTlNUQUxMX09QVFMpIHNhbXBs
ZS1jb25maWcvbmFnaW9zLmNmZyAkKERFU1RESVIpJChDRkdESVIpL25hZ2lvcy5jZmcKIAkk
KElOU1RBTEwpIC1iIC1tIDY2NCAkKElOU1RBTExfT1BUUykgc2FtcGxlLWNvbmZpZy9jZ2ku
Y2ZnICQoREVTVERJUikkKENGR0RJUikvY2dpLmNmZwogCSQoSU5TVEFMTCkgLWIgLW0gNjYw
ICQoSU5TVEFMTF9PUFRTKSBzYW1wbGUtY29uZmlnL3Jlc291cmNlLmNmZyAkKERFU1RESVIp
JChDRkdESVIpL3Jlc291cmNlLmNmZwpJbmRleDogbmFnaW9zLTMuMi4xL2NnaS9jZ2lhdXRo
LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gbmFnaW9zLTMuMi4xL2NnaS9jZ2lhdXRoLmMJKHJldmlz
aW9uIDE3NikKKysrIG5hZ2lvcy0zLjIuMS9jZ2kvY2dpYXV0aC5jCShyZXZpc2lvbiAyNzMp
CkBAIC0zNyw4ICszNyw5OCBAQAogZXh0ZXJuIGludCAgICAgICAgICAgICB1c2VfYXV0aGVu
dGljYXRpb247CiBleHRlcm4gaW50ICAgICAgICAgICAgIHVzZV9zc2xfYXV0aGVudGljYXRp
b247CiAKK2ludCBzZXRfYXV0aHpfcGVybWlzc2lvbnMoY2hhciogcGVybWlzc2lvbiwgYXV0
aGRhdGEqIGF1dGhpbmZvKSB7CisJaWYgKHN0cmNtcChwZXJtaXNzaW9uLCAiciIpID09IDAp
IHsgLyogb25seSByZWFkIHBlcm1pc3Npb25zICovCisJCWF1dGhpbmZvLT5hdXRob3JpemVk
X2Zvcl9yZWFkX29ubHkgPSBUUlVFOworCQlhdXRoaW5mby0+YXV0aG9yaXplZF9mb3Jfc3lz
dGVtX2luZm9ybWF0aW9uPVRSVUU7CisJCWF1dGhpbmZvLT5hdXRob3JpemVkX2Zvcl9jb25m
aWd1cmF0aW9uX2luZm9ybWF0aW9uPVRSVUU7CisJCWF1dGhpbmZvLT5hdXRob3JpemVkX2Zv
cl9zeXN0ZW1fY29tbWFuZHM9RkFMU0U7CisJCWF1dGhpbmZvLT5hdXRob3JpemVkX2Zvcl9h
bGxfc2VydmljZV9jb21tYW5kcz1GQUxTRTsKKwkJYXV0aGluZm8tPmF1dGhvcml6ZWRfZm9y
X2FsbF9ob3N0X2NvbW1hbmRzPUZBTFNFOworCX0gLyogcmVhZCArIHdyaXRlIHBlcm1pc3Np
b25zICovCisJZWxzZSBpZiAoc3RyY21wKHBlcm1pc3Npb24sICJ3IikgPT0gMCkgeworCQlh
dXRoaW5mby0+YXV0aG9yaXplZF9mb3JfcmVhZF9vbmx5PUZBTFNFOworCQlhdXRoaW5mby0+
YXV0aG9ya
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
--------------050608040507020701050101
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
2010-11-15 17:26 keltez=C3=A9ssel, V=C3=A1g=C3=B3 Tibor =C3=ADrta:
> 2010-11-03 11:43 keltez=C3=A9ssel, Andreas Ericsson =C3=ADrta:
>> On 11/02/2010 07:23 PM, V=C3=A1g=C3=B3 Tibor wrote:
>>> Hi Andreas,
>>>
>>> ok, thanks for your information.
>>>
>>
>> I've had a peak. The patch is extremely weirdly indented, making
>> it hard to follow. Spaces are mixed with tabs and the tabsetting
>> seems to be non-standard.
>>
>> Re-indent your parts of the code to either match the current
>> coding standards or to match those used in the linux kernel
>> project and re-submit a new diff. Then I'll have a look again.
>
> Dear Andreas,
>
> here is the reformatted nicely tabbed diff file.
>
> In this patch I've changed the authorization filename from
> "authorization.cfg" to "cgiauth.cfg" too.
Hi,
Sorry, but NIIFI specific attributes was remain in the patch, so I=20
resend the stripped and more detailed version of patch.
Thanks,
Tibor
--------------050608040507020701050101
Content-Type: text/plain;
name="authorization.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="authorization.patch"
SW5kZXg6IG5hZ2lvcy0zLjIuMS9jb25maWd1cmUKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbmFnaW9z
LTMuMi4xL2NvbmZpZ3VyZQkocmV2aXNpb24gMTc2KQorKysgbmFnaW9zLTMuMi4xL2NvbmZp
Z3VyZQkocmV2aXNpb24gMjczKQpAQCAtOTE4Niw2ICs5MTg2LDcgQEAKIAogcGVybCBzdWJz
dCBzYW1wbGUtY29uZmlnL25hZ2lvcy5jZmcKIHBlcmwgc3Vic3Qgc2FtcGxlLWNvbmZpZy9j
Z2kuY2ZnCitwZXJsIHN1YnN0IHNhbXBsZS1jb25maWcvY2dpYXV0aC5jZmcKIHBlcmwgc3Vi
c3Qgc2FtcGxlLWNvbmZpZy9yZXNvdXJjZS5jZmcKIHBlcmwgc3Vic3Qgc2FtcGxlLWNvbmZp
Zy9odHRwZC5jb25mCiBwZXJsIHN1YnN0IHNhbXBsZS1jb25maWcvbXJ0Zy5jZmcKSW5kZXg6
IG5hZ2lvcy0zLjIuMS9NYWtlZmlsZS5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBuYWdpb3MtMy4y
LjEvTWFrZWZpbGUuaW4JKHJldmlzaW9uIDE3NikKKysrIG5hZ2lvcy0zLjIuMS9NYWtlZmls
ZS5pbgkocmV2aXNpb24gMjczKQpAQCAtMjQzLDYgKzI0Myw3IEBACiBpbnN0YWxsLWNvbmZp
ZzoKIAkkKElOU1RBTEwpIC1tIDc3NSAkKElOU1RBTExfT1BUUykgLWQgJChERVNURElSKSQo
Q0ZHRElSKQogCSQoSU5TVEFMTCkgLW0gNzc1ICQoSU5TVEFMTF9PUFRTKSAtZCAkKERFU1RE
SVIpJChDRkdESVIpL29iamVjdHMKKwkkKElOU1RBTEwpIC1iIC1tIDY2NCAkKElOU1RBTExf
T1BUUykgc2FtcGxlLWNvbmZpZy9jZ2lhdXRoLmNmZyAkKERFU1RESVIpJChDRkdESVIpL2Nn
aWF1dGguY2ZnCiAJJChJTlNUQUxMKSAtYiAtbSA2NjQgJChJTlNUQUxMX09QVFMpIHNhbXBs
ZS1jb25maWcvbmFnaW9zLmNmZyAkKERFU1RESVIpJChDRkdESVIpL25hZ2lvcy5jZmcKIAkk
KElOU1RBTEwpIC1iIC1tIDY2NCAkKElOU1RBTExfT1BUUykgc2FtcGxlLWNvbmZpZy9jZ2ku
Y2ZnICQoREVTVERJUikkKENGR0RJUikvY2dpLmNmZwogCSQoSU5TVEFMTCkgLWIgLW0gNjYw
ICQoSU5TVEFMTF9PUFRTKSBzYW1wbGUtY29uZmlnL3Jlc291cmNlLmNmZyAkKERFU1RESVIp
JChDRkdESVIpL3Jlc291cmNlLmNmZwpJbmRleDogbmFnaW9zLTMuMi4xL2NnaS9jZ2lhdXRo
LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gbmFnaW9zLTMuMi4xL2NnaS9jZ2lhdXRoLmMJKHJldmlz
aW9uIDE3NikKKysrIG5hZ2lvcy0zLjIuMS9jZ2kvY2dpYXV0aC5jCShyZXZpc2lvbiAyNzMp
CkBAIC0zNyw4ICszNyw5OCBAQAogZXh0ZXJuIGludCAgICAgICAgICAgICB1c2VfYXV0aGVu
dGljYXRpb247CiBleHRlcm4gaW50ICAgICAgICAgICAgIHVzZV9zc2xfYXV0aGVudGljYXRp
b247CiAKK2ludCBzZXRfYXV0aHpfcGVybWlzc2lvbnMoY2hhciogcGVybWlzc2lvbiwgYXV0
aGRhdGEqIGF1dGhpbmZvKSB7CisJaWYgKHN0cmNtcChwZXJtaXNzaW9uLCAiciIpID09IDAp
IHsgLyogb25seSByZWFkIHBlcm1pc3Npb25zICovCisJCWF1dGhpbmZvLT5hdXRob3JpemVk
X2Zvcl9yZWFkX29ubHkgPSBUUlVFOworCQlhdXRoaW5mby0+YXV0aG9yaXplZF9mb3Jfc3lz
dGVtX2luZm9ybWF0aW9uPVRSVUU7CisJCWF1dGhpbmZvLT5hdXRob3JpemVkX2Zvcl9jb25m
aWd1cmF0aW9uX2luZm9ybWF0aW9uPVRSVUU7CisJCWF1dGhpbmZvLT5hdXRob3JpemVkX2Zv
cl9zeXN0ZW1fY29tbWFuZHM9RkFMU0U7CisJCWF1dGhpbmZvLT5hdXRob3JpemVkX2Zvcl9h
bGxfc2VydmljZV9jb21tYW5kcz1GQUxTRTsKKwkJYXV0aGluZm8tPmF1dGhvcml6ZWRfZm9y
X2FsbF9ob3N0X2NvbW1hbmRzPUZBTFNFOworCX0gLyogcmVhZCArIHdyaXRlIHBlcm1pc3Np
b25zICovCisJZWxzZSBpZiAoc3RyY21wKHBlcm1pc3Npb24sICJ3IikgPT0gMCkgeworCQlh
dXRoaW5mby0+YXV0aG9yaXplZF9mb3JfcmVhZF9vbmx5PUZBTFNFOworCQlhdXRoaW5mby0+
YXV0aG9ya
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]