Nagios Support Forum

This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.

---187430788-1712018757-1199056876=:21818
Content-Type: TEXT/PLAIN; CHARSET=ISO-8859-2; FORMAT=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID:

Hello,

This patch properly terminates the "output" string so both returned and log=
ged=20
(syslog) values are correct.

The bug was introduced in nrpe-2.8 (multiline plugin output) - previously t=
he=20
child process was able to return a properly termintaed c-string but now, wh=
en=20
fread() is used instead of fgets(), the received string (output) is not=20
terminated and my_system() returns and logs some kind of garbage.

I also decided to remove two unused variables.

Best regards,

=09=09=09Krzysztof Ol=EAdzki
---187430788-1712018757-1199056876=:21818
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME=nrpe-fix-output.patch
Content-Transfer-Encoding: BASE64
Content-ID:
Content-Description:
Content-Disposition: ATTACHMENT; FILENAME=nrpe-fix-output.patch

LS0tIG5ycGUtMi4xMC1vcmlnL3NyYy9ucnBlLmMJMjAwNy0xMC0xOSAxNTox
ODo1Ny4wMDAwMDAwMDAgKzAyMDANCisrKyBucnBlLTIuMTAvc3JjL25ycGUu
YwkyMDA3LTEyLTMxIDAwOjA5OjU4LjAwMDAwMDAwMCArMDEwMA0KQEAgLTEy
NTUsNyArMTI1NSw2IEBADQogCWludCByZXN1bHQ7DQogCWV4dGVybiBpbnQg
ZXJybm87DQogCWNoYXIgYnVmZmVyW01BWF9JTlBVVF9CVUZGRVJdOw0KLQlj
aGFyIHRlbXBfYnVmZmVyW01BWF9JTlBVVF9CVUZGRVJdOw0KIAlpbnQgZmRb
Ml07DQogCUZJTEUgKmZwOw0KIAlpbnQgYnl0ZXNfcmVhZD0wOw0KQEAgLTEz
ODUsMTQgKzEzODQsMTUgQEANCiANCiAJCS8qIHRyeSBhbmQgcmVhZCB0aGUg
cmVzdWx0cyBmcm9tIHRoZSBjb21tYW5kIG91dHB1dCAocmV0cnkgaWYgd2Ug
ZW5jb3VudGVyZWQgYSBzaWduYWwpICovDQogCQlpZihvdXRwdXQhPU5VTEwp
ew0KLQkJCXN0cmNweShvdXRwdXQsIiIpOw0KLQkJCWRvew0KLQkJCQlieXRl
c19yZWFkPXJlYWQoZmRbMF0sb3V0cHV0LG91dHB1dF9sZW5ndGgtMSk7DQot
CQkgICAgICAgICAgICAgICAgfXdoaWxlKGJ5dGVzX3JlYWQ9PS0xICYmIGVy
cm5vPT1FSU5UUik7DQotCQkgICAgICAgIH0NCisJCQlkbyB7DQorCQkJCWJ5
dGVzX3JlYWQ9cmVhZChmZFswXSwgb3V0cHV0LCBvdXRwdXRfbGVuZ3RoLTEp
Ow0KKwkJCX0gd2hpbGUgKGJ5dGVzX3JlYWQ9PS0xICYmIGVycm5vPT1FSU5U
Uik7DQogDQotCQlpZihieXRlc19yZWFkPT0tMSAmJiBvdXRwdXQhPU5VTEwp
DQotCQkJc3RyY3B5KG91dHB1dCwiIik7DQorCQkJaWYgKGJ5dGVzX3JlYWQ9
PS0xKQ0KKwkJCQkqb3V0cHV0ID0gJ1wwJzsNCisJCQllbHNlDQorCQkJCW91
dHB1dFtieXRlc19yZWFkXSA9ICdcMCc7DQorCQl9DQogDQogCQkvKiBpZiB0
aGVyZSB3YXMgYSBjcml0aWNhbCByZXR1cm4gY29kZSBhbmQgbm8gb3V0cHV0
IEFORCB0aGUgY29tbWFuZCB0aW1lIGV4Y2VlZGVkIHRoZSB0aW1lb3V0IHRo
cmVzaG9sZHMsIGFzc3VtZSBhIHRpbWVvdXQgKi8NCiAJCWlmKHJlc3VsdD09
U1RBVEVfQ1JJVElDQUwgJiYgYnl0ZXNfcmVhZD09LTEgJiYgKGVuZF90aW1l
LXN0YXJ0X3RpbWUpPj10aW1lb3V0KXsNCkBAIC0xNjAyLDcgKzE2MDIsNiBA
QA0KIHZvaWQgc2lnaGFuZGxlcihpbnQgc2lnKXsNCiAJc3RhdGljIGNoYXIg
KnNpZ3NbXT17IkVYSVQiLCJIVVAiLCJJTlQiLCJRVUlUIiwiSUxMIiwiVFJB
UCIsIkFCUlQiLCJCVVMiLCJGUEUiLCJLSUxMIiwiVVNSMSIsIlNFR1YiLCJV
U1IyIiwiUElQRSIsIkFMUk0iLCJURVJNIiwiU1RLRkxUIiwiQ0hMRCIsIkNP
TlQiLCJTVE9QIiwiVFNUUCIsIlRUSU4iLCJUVE9VIiwiVVJHIiwiWENQVSIs
IlhGU1oiLCJWVEFMUk0iLCJQUk9GIiwiV0lOQ0giLCJJTyIsIlBXUiIsIlVO
VVNFRCIsIlpFUlIiLCJERUJVRyIsKGNoYXIgKilOVUxMfTsNCiAJaW50IGk7
DQotCWNoYXIgdGVtcF9idWZmZXJbTUFYX0lOUFVUX0JVRkZFUl07DQogDQog
CWlmKHNpZzwwKQ0KIAkJc2lnPS1zaWc7DQo=

---187430788-1712018757-1199056876=:21818--





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]