Re: [Nagios-devel] Embedded sounds in Nagios 3
Posted: Fri Jul 18, 2008 7:51 am
Jonathan Clarke wrote:
> Hi,
>
> I've been testing the sound embedded in pages on Nagios 3.0.3. Comparing
> it to a clean install of Nagios 2, I noticed these two points:
>
> 1) There was a bug in the "Tactical overview" page, and the path to the
> sound file was not included in the HTML output.
>
> 2) On a Windows machine, neither Firefox nor IE plays the sound
> I tracked this down to the "type" parameter in the HTML, which was
> changed from "application/x-mplayer2" to "application/wav".
>
> Please find attached a patch that corrects these two points, on the
> 3.0.3 source code.
>
Your patch is back-to-front. Seems like you did
diff -u new old
when the syntax to do it is supposed to be
diff -u old new
As it is, the patch applies correctly with "patch -p1 -R While 1 is obviously just a typo, I imagine that 2 was a deliberate
> change
Maybe there is a better solution than just reverting this?
>
application/x-wav should be correct, I think, although I neither know
nor care.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> Hi,
>
> I've been testing the sound embedded in pages on Nagios 3.0.3. Comparing
> it to a clean install of Nagios 2, I noticed these two points:
>
> 1) There was a bug in the "Tactical overview" page, and the path to the
> sound file was not included in the HTML output.
>
> 2) On a Windows machine, neither Firefox nor IE plays the sound
> I tracked this down to the "type" parameter in the HTML, which was
> changed from "application/x-mplayer2" to "application/wav".
>
> Please find attached a patch that corrects these two points, on the
> 3.0.3 source code.
>
Your patch is back-to-front. Seems like you did
diff -u new old
when the syntax to do it is supposed to be
diff -u old new
As it is, the patch applies correctly with "patch -p1 -R While 1 is obviously just a typo, I imagine that 2 was a deliberate
> change
Maybe there is a better solution than just reverting this?>
application/x-wav should be correct, I think, although I neither know
nor care.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]