Re: [Nagios-devel] [PATCH 2/2] lib/worker: Remove dead code
Posted: Fri Nov 02, 2012 10:31 am
On 11/01/2012 05:38 PM, [email protected] wrote:
> From: Robin Sonefors
>
> This removes a method that was part of the public lib/worker API that
> hasn't been used since nagios started using its own query handler for
> spawning workers. It was highly specific to the old worker spawning
> code, meaning it's of little general use.
>
> It also removes two members of the worker ABI that always pointed to
> NULL, which uses up (a little) RAM, and (a little more, due to confusion
> when examining core dumps) developer time.
>
> Signed-off-by: Robin Sonefors
Declined. The lib/wproc binary still uses this function, so it's a no-go
for the time being. Moving it to lib/wproc.c would make sense, but I'm
not going to bother with that right now.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> From: Robin Sonefors
>
> This removes a method that was part of the public lib/worker API that
> hasn't been used since nagios started using its own query handler for
> spawning workers. It was highly specific to the old worker spawning
> code, meaning it's of little general use.
>
> It also removes two members of the worker ABI that always pointed to
> NULL, which uses up (a little) RAM, and (a little more, due to confusion
> when examining core dumps) developer time.
>
> Signed-off-by: Robin Sonefors
Declined. The lib/wproc binary still uses this function, so it's a no-go
for the time being. Moving it to lib/wproc.c would make sense, but I'm
not going to bother with that right now.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]