Re: [Nagios-devel] Do not launch a shell for each check
Posted: Mon Oct 04, 2010 1:54 am
Ton Voon wrote:
> On 29 Sep 2010, at 12:36, Matthieu Kermagoret wrote:
>
>> On Tue, Jun 1, 2010 at 3:49 PM, Matthieu Kermagoret
>> wrote:
>>> The patch I propose, handle simple commands with shell quoting
>>> (simple
>>> and double quote). Every command containing any of these characters
>>> (escaped or not) will be handled by the shell --> !$^&*()~[]|{};?`
>>> >>
>>> So any feedback on this new proposal ?
>>>
>> Could it somehow make it into HEAD ? It would resolve issue #86.
>
> Is it possible to get some libtap tests running against these?
>
> If so, I'd be happy to review what you have done in the tests.
>
> However, this is quite an intrusive change, so would have to go into
> the next feature branch.
>
> Ton
Agreed - Nice idea, but it should probably wait for a 3.3.x release.
Once I release 3.2.3, I'll create a 3.2.x branch and this can get
committed to HEAD.
--
Ethan Galstad
Father of Nagios
___
Email: [email protected]|com
Web: www.nagios.com
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> On 29 Sep 2010, at 12:36, Matthieu Kermagoret wrote:
>
>> On Tue, Jun 1, 2010 at 3:49 PM, Matthieu Kermagoret
>> wrote:
>>> The patch I propose, handle simple commands with shell quoting
>>> (simple
>>> and double quote). Every command containing any of these characters
>>> (escaped or not) will be handled by the shell --> !$^&*()~[]|{};?`
>>> >>
>>> So any feedback on this new proposal ?
>>>
>> Could it somehow make it into HEAD ? It would resolve issue #86.
>
> Is it possible to get some libtap tests running against these?
>
> If so, I'd be happy to review what you have done in the tests.
>
> However, this is quite an intrusive change, so would have to go into
> the next feature branch.
>
> Ton
Agreed - Nice idea, but it should probably wait for a 3.3.x release.
Once I release 3.2.3, I'll create a 3.2.x branch and this can get
committed to HEAD.
--
Ethan Galstad
Father of Nagios
___
Email: [email protected]|com
Web: www.nagios.com
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]