Page 1 of 1

Re: [Nagios-devel] Patch for Circular Paths (new algo) 70s->0.007s

Posted: Tue May 13, 2008 10:00 am
by Guest
------=_Part_1927_29219976.1210701599115
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Ethan, Hi list,

I test the current cvs version and the circular host check is still slow:
current version:
CONFIG VERIFICATION TIMES (* =3D Potential for speedup with -x opt=
ion)
----------------------------------
Object Relationships: 0.582019 sec
Circular Paths: 9.895108 sec *
Misc: 0.003989 sec
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
TOTAL: 10.481116 sec * =3D 9.895108 sec (94.4%) estimated s=
avings


I make the circular patch for the current version and I try it:
CONFIG VERIFICATION TIMES (* =3D Potential for speedup with -x opt=
ion)
----------------------------------
Object Relationships: 0.580119 sec
Circular Paths: 0.268966 sec *
Misc: 0.003847 sec
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
TOTAL: 0.852932 sec * =3D 0.268966 sec (31.5%) estimated sa=
vings

Can you have a look to it? I can give you my cfg file for the check.

Thanks,


Gab=E8s Jean


On Sat, Feb 2, 2008 at 8:35 PM, nap wrote:
> Of course, I forgot the temp.cfg. sorry.
>
>
> Jean
>
>
>
> On Feb 2, 2008 7:32 PM, nap wrote:
> > Hi list,
> >
> > I test a difficult sample (like your one Andreas). The test.cfg is the
> > configuration file for nagios, and circular_check.png is a image of
> > the configuration, and all the loops :)
> > Red items are bad: the are in loops, green are OK. Red items need to
> > be in error state, and just them. I realize my previous patch showed
> > too much errors when a host was in 2 differents loops. Now It's OK.
> >
> > I change the output of my patch to fit exactly to the original output.
> >
> > You can use test.cfg and had some nasty parents relations, and see if
> > the patch show all errors.
> >
> >
> > Jean
> >
> >
> >
> > On Feb 1, 2008 11:44 AM, nap wrote:
> > > Hi,
> > >
> > > Here is the patch without the space. I just test it and it apply to
> > > the cvs version.
> > >
> > > I'll check for the object.cache and try to make mode funny samples
> > > (I'll become a master of awk after that...). I think the exemple you
> > > give will be ok with my algo (it's a standard algo for check graphs)=
,
> > > and we check a node one and only one time so no problem with
> > > complexity I think. I'll post the sample, but if you already have so=
me
> > > special case, I take them :)
> > > You can see the test.cfg. It's the sample with a loop. But it's a si=
mple loop.
> > >
> > > I'm ok with your conclusion, if the algo if false, it's useless ;)
> > >
> > > I'll work for big complex sample this week-end, if you don't post th=
e
> > > results monday, it's that i'm dead while reading the man of awk.
> > >
> > > After that, I'll trace the services dependencies check.
> > >
> > >
> > > Jean
> > >
> > >
> > >
> > > On Feb 1, 2008 11:26 AM, Andreas Ericsson wrote:
> > > > Andreas Ericsson wrote:
> > > > > nap wrote:
> > > > >> Hi list,
> > > > >>
> > > > >> I finish my patch for the host path part. I try to folow the
> > > > >> indentation and the coding style of nagios.
> > > > >
> > > > > It looks a lot better now. For extra points, remove the hunks th=
at
> > > > > only insert whitespace changes.
> > > > >
> > > > >> you can find test files with a lot of parent/childs at
> > > > >> http://zegabes.free.fr/nagios/ .
> > > > >>
> > > > >
> > > > > What's lacking from that place is the objects.cache using the ol=
d
> > > > > code and one generated using the new one, especially with multip=
le
> > > > > parents, as well as a diff between them so one can see what, if =
any,
> > > > > the differences are.
> > > > >
> > > >
> > > > I take that back. What's lacking is a proper test-case. If the con=
fig
> > > > you've been using to test is the one on that site, you haven't eve=
n
> > > > scratched at the funnier configs one sometimes see.
> >

...[email truncated]...


This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]