Re: [Nagios-devel] invalid perfdata from check_icmp (patch)
Posted: Mon May 12, 2008 6:12 am
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Ericsson wrote:
| Wolfgang wrote:
|> Somebody on the german nagios forum used a symbolic link (check_host)
to check_icmp. In hostcheck mode the perfdata output of check_icmp is
somewhat incomplete as no valid warning value is returned which leads to
an error if using functions to process the values.
|>
|
| According to the nagiosplugin guidelines, the warning value isn't required
| in performance data output. A parser expecting to find a value there is
| broken and needs to be fixed. Adding a false warning value to the plugin
| itself is not the right fix.
Although I totally forgot to reply this week-end, that was my thought as
well. While some plugins force users to specify warning and critical
thresholds this behavior (which is broken IMHO) will definitely change
with the new thresholds syntax.
If someone wants some data just to view it from the host detail page,
and/or to graph it, that's perfectly fine. In these cases the threshold
part of the performance data should be empty.
- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIKFA/6dZ+Kt5BchYRAlpjAJ9SeJYOyB5sIWO97bczw6uy64ziawCeNXfB
uvCGuEwHtqc2cAX5TMHJo/M=
=8ofk
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Hash: SHA1
Andreas Ericsson wrote:
| Wolfgang wrote:
|> Somebody on the german nagios forum used a symbolic link (check_host)
to check_icmp. In hostcheck mode the perfdata output of check_icmp is
somewhat incomplete as no valid warning value is returned which leads to
an error if using functions to process the values.
|>
|
| According to the nagiosplugin guidelines, the warning value isn't required
| in performance data output. A parser expecting to find a value there is
| broken and needs to be fixed. Adding a false warning value to the plugin
| itself is not the right fix.
Although I totally forgot to reply this week-end, that was my thought as
well. While some plugins force users to specify warning and critical
thresholds this behavior (which is broken IMHO) will definitely change
with the new thresholds syntax.
If someone wants some data just to view it from the host detail page,
and/or to graph it, that's perfectly fine. In these cases the threshold
part of the performance data should be empty.
- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIKFA/6dZ+Kt5BchYRAlpjAJ9SeJYOyB5sIWO97bczw6uy64ziawCeNXfB
uvCGuEwHtqc2cAX5TMHJo/M=
=8ofk
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]