Re: [Nagios-devel] Patch to clean illegal characters from some macros
Posted: Tue Feb 08, 2005 3:49 pm
The macro patch that's on its way to CVS should handle this. All
output and perfdata maros should now be cleaned properly.
On 4 Feb 2005 at 23:34, Stanley Hopcroft wrote:
> Dear Folks,
>
> I think Nagios 2.0b1 needs this patch is needed to ensure that illegal
> characters from macros used in notify command do not confuse the shell
> when it comes to execute the macro substitued notify command.
>
> For example, my employer's Nag checks CGIs that require '&'
> in the query_strings.
>
> When such a check fails it usually outputs the failed request -
> including the '&' characters.
>
> If in addition, the quoting of the macros breaks down - because the
> plugin output also contains '"" characters, the notify command will
> fail.
>
> I am not sure if this isn't better done in the get_macro_ functions,
> but this seems to work for me (in production for about 5 minutes now
> ...)
>
> Yours sincerely.
>
> --
> Stanley Hopcroft
>
> IP Australia
> Ph: (02) 6283 3189 Fax: (02) 6281 1353
> PO Box 200 Woden ACT 2606
> http://www.ipaustralia.gov.au
>
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
output and perfdata maros should now be cleaned properly.
On 4 Feb 2005 at 23:34, Stanley Hopcroft wrote:
> Dear Folks,
>
> I think Nagios 2.0b1 needs this patch is needed to ensure that illegal
> characters from macros used in notify command do not confuse the shell
> when it comes to execute the macro substitued notify command.
>
> For example, my employer's Nag checks CGIs that require '&'
> in the query_strings.
>
> When such a check fails it usually outputs the failed request -
> including the '&' characters.
>
> If in addition, the quoting of the macros breaks down - because the
> plugin output also contains '"" characters, the notify command will
> fail.
>
> I am not sure if this isn't better done in the get_macro_ functions,
> but this seems to work for me (in production for about 5 minutes now
> ...)
>
> Yours sincerely.
>
> --
> Stanley Hopcroft
>
> IP Australia
> Ph: (02) 6283 3189 Fax: (02) 6281 1353
> PO Box 200 Woden ACT 2606
> http://www.ipaustralia.gov.au
>
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]