On 11/19/2010 10:49 AM, Allan Clark wrote:
> On Fri, Nov 19, 2010 at 04:38, Andreas Ericsson wrote:
>> [...]
>> Unless someone complains before monday I'll add a Makefile target
>> to indent the sources, run it once and then commit the results, with
>> a note added so that future contributors know what to do to make
>> their code conform to the standard.
>>
>> vim and emacs users should look into using their editors respective
>> 'smart tabs' settings. Most decent editors support aligning with
>> spaces and indenting with tabs nowadays, but if you're not using one
>> of them, you can just run 'make pretty' or 'make indent' before you
>> submit your patches.
>
> Why not make it an indentation filter in the .wrapper?
>
Because it's not scm-agnostic and we really, really hate cvs.
> That way, whatever formatting-butchery people accidentally do in their
> editors, the checkin is re-normalized automatically at the point of
> checkin.
>
A janitor commit every other month setting the style right (when patch
review lets one or more poorly formatted ones through) should be enough
to keep things mostly correct though.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]