Re: [Nagios-devel] [Nagios-users] Nagios retention problem.
Posted: Thu Nov 20, 2008 9:28 am
[email protected] wrote:
> I move this thred to 'dev' instead. It seems to fit better there.
>
> Problem solved.
>
> Nagios does'nt check the return value from the fclose() call when
> closing the tempfile used to write retention.dat. Before I upgraded to
> Nagios 3 I hade severe performance problems, so I moved all temp-files
> to ramdisks for higher performance which worked well. But when the
> number of services increased after upgrading the ramdisk was'nt big
> enough.
>
> Since there were no log entry, and the ramdisks were only about 40-50%
> full, I did'nt think this was the problem - after all the ramdisk were
> only 100% full between the closing of the tempfile until Nagios changed
> the name of the tempfile to "retention.dat".
>
> Anyway. I've rewritten the code a little so that Nagios checks the
> fclose() return value, and if there is a problem a log entry is written.
> Also Nagios does not change the name of the tempfile, so the old
> retention data is saved instead of the new corropt data.
>
> Are you people interested in the patch?
>
Yes.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> I move this thred to 'dev' instead. It seems to fit better there.
>
> Problem solved.
>
> Nagios does'nt check the return value from the fclose() call when
> closing the tempfile used to write retention.dat. Before I upgraded to
> Nagios 3 I hade severe performance problems, so I moved all temp-files
> to ramdisks for higher performance which worked well. But when the
> number of services increased after upgrading the ramdisk was'nt big
> enough.
>
> Since there were no log entry, and the ramdisks were only about 40-50%
> full, I did'nt think this was the problem - after all the ramdisk were
> only 100% full between the closing of the tempfile until Nagios changed
> the name of the tempfile to "retention.dat".
>
> Anyway. I've rewritten the code a little so that Nagios checks the
> fclose() return value, and if there is a problem a log entry is written.
> Also Nagios does not change the name of the tempfile, so the old
> retention data is saved instead of the new corropt data.
>
> Are you people interested in the patch?
>
Yes.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]