Re: [Nagios-devel] PATCH: Allow escaping ! in check args (utils.c)
Posted: Wed May 17, 2006 3:12 pm
Bob Ingraham wrote:
> Gents,
>
> Please find attached a patch (in unified diff context,) for the following:
>
> My work had me create a patch for the get_raw_command_line() function in
> utils.c to allow us to "escape" the "!" argument separator within check
> command arguments.
>
> I generalized it such that you can actually escape any character by
> prefacing it with a backslash ('\'). So, now you can have command args
> that include exclamations points as part of the argmument string.
>
> For example:
>
> check_command check_web!www.nagios.org!80!\!Test\!String\!!10!20
>
> This will pass the third argument as: "!Test!String!" (sans quotes)
>
> Bob
>
Thanks for the patch! I'll apply similiar functionality to the Nagios
3.0 CVS code (the code differs a bit from 2.x). I don't see a need to
allow for escaping of the first ! delimiter in the command line, as it
seems unlikely that anyone would need/want to define a command with an
exclamation point.
Patch will be in CVS soon. Thanks again!
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> Gents,
>
> Please find attached a patch (in unified diff context,) for the following:
>
> My work had me create a patch for the get_raw_command_line() function in
> utils.c to allow us to "escape" the "!" argument separator within check
> command arguments.
>
> I generalized it such that you can actually escape any character by
> prefacing it with a backslash ('\'). So, now you can have command args
> that include exclamations points as part of the argmument string.
>
> For example:
>
> check_command check_web!www.nagios.org!80!\!Test\!String\!!10!20
>
> This will pass the third argument as: "!Test!String!" (sans quotes)
>
> Bob
>
Thanks for the patch! I'll apply similiar functionality to the Nagios
3.0 CVS code (the code differs a bit from 2.x). I don't see a need to
allow for escaping of the first ! delimiter in the command line, as it
seems unlikely that anyone would need/want to define a command with an
exclamation point.
Patch will be in CVS soon. Thanks again!Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]