Re: [Nagios-devel] [PATCH] fix datarootdir warnings by autoconf 2.61
Posted: Wed Jun 10, 2009 7:42 am
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Ericsson schrieb:
> Ton Voon wrote:
>> Hi Hendrik,
>>
>> On 30 May 2009, at 20:39, Hendrik Baecker wrote:
>>
>>> After upgrading from autoconf 2.59 to 2.61 a new
>>> option was givven: --datarootdir
>>> The datarootdir replaces the old htmldir/datadir in
>>> subst.in and Makefile.in files.
>>>
>>> This patch fixes some minor makefile cleanups for the new t-tap
>>> directory. A 'make distclean' will result in a really clean
>>> directory.
>> I've applied the t-tap cleanups - thanks.
>>
>> I haven't applied the datarootdir option. I'm not sure what we are
>> doing regarding autoconf and other dev tools.
>>
>> Ethan, Andreas, any thoughts? For the plugins, we list the developer
>> requirements and we do not commit any files that are auto generated.
>>
>
> I agree 100% with not committing autogenerated files. Such files should
> ofcourse be included in releases, but having them in the repo is just so
> much dead weight.
>
So you want one extra step for those guys who are dealing with the
latest head?
IMO the change frequency of autogenerated files like configure isn't
too high to save larger commit diffs caused by this fileclass.
Where do you see a problem after changing some code which needs an
update of the configure.in stuff to rebuild configure by the developer
and check this in?
As long all dev members are using the same autoconf version I don't
see a big problem.
Is it safer to don't commit those file for the development process?
- -
Hendrik
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
iD8DBQFKL3GflI0PwfxLQjkRAnB3AJ9WOkf7cVAe4xYsycj7sxGrp5860wCfdd0B
pF3v/VcYkiMhJdFp8rm6PkY=
=4PDj
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Hash: SHA1
Andreas Ericsson schrieb:
> Ton Voon wrote:
>> Hi Hendrik,
>>
>> On 30 May 2009, at 20:39, Hendrik Baecker wrote:
>>
>>> After upgrading from autoconf 2.59 to 2.61 a new
>>> option was givven: --datarootdir
>>> The datarootdir replaces the old htmldir/datadir in
>>> subst.in and Makefile.in files.
>>>
>>> This patch fixes some minor makefile cleanups for the new t-tap
>>> directory. A 'make distclean' will result in a really clean
>>> directory.
>> I've applied the t-tap cleanups - thanks.
>>
>> I haven't applied the datarootdir option. I'm not sure what we are
>> doing regarding autoconf and other dev tools.
>>
>> Ethan, Andreas, any thoughts? For the plugins, we list the developer
>> requirements and we do not commit any files that are auto generated.
>>
>
> I agree 100% with not committing autogenerated files. Such files should
> ofcourse be included in releases, but having them in the repo is just so
> much dead weight.
>
So you want one extra step for those guys who are dealing with the
latest head?
IMO the change frequency of autogenerated files like configure isn't
too high to save larger commit diffs caused by this fileclass.
Where do you see a problem after changing some code which needs an
update of the configure.in stuff to rebuild configure by the developer
and check this in?
As long all dev members are using the same autoconf version I don't
see a big problem.
Is it safer to don't commit those file for the development process?
- -
Hendrik
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
iD8DBQFKL3GflI0PwfxLQjkRAnB3AJ9WOkf7cVAe4xYsycj7sxGrp5860wCfdd0B
pF3v/VcYkiMhJdFp8rm6PkY=
=4PDj
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]