Re: [Nagios-devel] Non existent macros are not replaced
Posted: Thu Mar 03, 2011 7:08 pm
On 03/03/2011 07:33 PM, Andreas Ericsson wrote:
> On 03/03/2011 06:37 PM, Jochen Bern wrote:
>> Not quite, the handling of escaped dollar signs ("$$") is in a separat=
e
>> branch immediately preceding the "unknown macro name" branch. Hence, t=
he
>> properly escaped notation ("$$FOO$$BAR" in Nagios, becomes "$FOO$BAR" =
on
>> shell level) would still be available.
>=20
> Yes, but how about a command_line such as this:
> $USER1$/check_something '$pas$word'
> $pas$ is not a valid macro, so by the reasoning of the original poster
> we should remove it, but that would mean there can *never* be two
> dollar-signs that aren't part of macros inside anything where macros
> get interpreted
I'm not saying that you should follow his reasoning, but why you keep
ignoring the official escaping method?
"Also, if you want to pass a dollar sign ($) on the command line, you
have to escape it with another dollar sign."
-- http://nagios.sourceforge.net/docs/3_0/ ... ml#command
# grep -n 'pas.*word' ../var/objects.cache
612: command_name test_password
613: command_line /bin/echo '$$pas$$word'
35520: check_command test_password
# grep -n 'pas.*word' ../var/spool/status.dat
54898: check_command=3Dtest_password
54924: plugin_output=3D$pas$word
>> On one hand, trusting Nagios to leave "$FOO$" be (rather than properly
>> configuring "$$FOO$$") is not supported.
>=20
> It is. If the dollar-signs are within single-quotes the shell won't eve=
n
> touch them and '$FOO$' gets passed verbatim to whatever command one's
> trying to run.
The above quote from the docs says it isn't ("you HAVE to"). But as I
said, *enforcing* that out of the blue sky is problematic, to say the lea=
st.
Kind regards,
J. Bern
--=20
Jochen Bern, Systemingenieur --- LINworks GmbH
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP =3D D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C2=
7
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Gesch=E4ftsf=FChrer Metin Dogan, Oliver Mic=
hel
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> On 03/03/2011 06:37 PM, Jochen Bern wrote:
>> Not quite, the handling of escaped dollar signs ("$$") is in a separat=
e
>> branch immediately preceding the "unknown macro name" branch. Hence, t=
he
>> properly escaped notation ("$$FOO$$BAR" in Nagios, becomes "$FOO$BAR" =
on
>> shell level) would still be available.
>=20
> Yes, but how about a command_line such as this:
> $USER1$/check_something '$pas$word'
> $pas$ is not a valid macro, so by the reasoning of the original poster
> we should remove it, but that would mean there can *never* be two
> dollar-signs that aren't part of macros inside anything where macros
> get interpreted
I'm not saying that you should follow his reasoning, but why you keep
ignoring the official escaping method?
"Also, if you want to pass a dollar sign ($) on the command line, you
have to escape it with another dollar sign."
-- http://nagios.sourceforge.net/docs/3_0/ ... ml#command
# grep -n 'pas.*word' ../var/objects.cache
612: command_name test_password
613: command_line /bin/echo '$$pas$$word'
35520: check_command test_password
# grep -n 'pas.*word' ../var/spool/status.dat
54898: check_command=3Dtest_password
54924: plugin_output=3D$pas$word
>> On one hand, trusting Nagios to leave "$FOO$" be (rather than properly
>> configuring "$$FOO$$") is not supported.
>=20
> It is. If the dollar-signs are within single-quotes the shell won't eve=
n
> touch them and '$FOO$' gets passed verbatim to whatever command one's
> trying to run.
The above quote from the docs says it isn't ("you HAVE to"). But as I
said, *enforcing* that out of the blue sky is problematic, to say the lea=
st.
Kind regards,
J. Bern
--=20
Jochen Bern, Systemingenieur --- LINworks GmbH
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP =3D D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C2=
7
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Gesch=E4ftsf=FChrer Metin Dogan, Oliver Mic=
hel
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]