--0016e6d778c07af9490487f8405f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On Tue, Jun 1, 2010 at 11:21 AM, Andreas Ericsson wrote:
> On 05/31/2010 04:28 PM, Matthieu Kermagoret wrote:
>> I'd like to propose a performance patch for Nagios that reduces the
>> number of Nagios' descendant processes.
>>
>
> Thanks. The idea behind the patch is good. The patch itself is not so
> stellar though.
>
Thanks for your feedback. I rewrote it using Andreas' advice and Hiren
Patel's patch (who indeed already proposed a patch doing the same
thing here nine months ago :
http://article.gmane.org/gmane.network. ... devel/6971).
The patch I propose, handle simple commands with shell quoting (simple
and double quote). Every command containing any of these characters
(escaped or not) will be handled by the shell --> !$^&*()~[]|{};?`
<--
So any feedback on this new proposal ?
--=20
Matthieu KERMAGORET | D=C3=A9veloppeur
[email protected]
MERETHIS est =C3=A9diteur du logiciel Centreon.
--0016e6d778c07af9490487f8405f
Content-Type: text/x-patch; charset=US-ASCII; name="nagios_no_popen_r2.patch"
Content-Disposition: attachment; filename="nagios_no_popen_r2.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g9ws4ipj0
ZGlmZiAtTmF1ciBhL2Jhc2UvY2hlY2tzLmMgYi9iYXNlL2NoZWNrcy5jCi0tLSBhL2Jhc2UvY2hl
Y2tzLmMJMjAwOS0wOC0xMSAxODo1NjozOS4wMDAwMDAwMDAgKzAyMDAKKysrIGIvYmFzZS9jaGVj
a3MuYwkyMDEwLTA2LTAxIDE1OjE2OjM2Ljg1ODY2ODc3NiArMDIwMApAQCAtMzUsNiArMzUsNyBA
QAogLyojZGVmaW5lIERFQlVHX0NIRUNLUyovCiAvKiNkZWZpbmUgREVCVUdfSE9TVF9DSEVDS1Mg
MSovCiAKKyNkZWZpbmUgTUFYX0NNRF9BUkdTIDQwOTYKIAogI2lmZGVmIEVNQkVEREVEUEVSTAog
I2luY2x1ZGUgIi4uL2luY2x1ZGUvZXBuX25hZ2lvcy5oIgpAQCAtMTI0LDYgKzEyNSwxMzMgQEAK
IAogCiAKKy8qKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKiovCisvKioqKioqKioqKioqKioqKioqKioqIE1JU0NFTExBTkVPVVMg
RlVOQ1RJT05TICoqKioqKioqKioqKioqKioqKioqLworLyoqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KKworLyogZXh0cmFj
dCBjaGVjayByZXN1bHQgKi8KK3N0YXRpYyB2b2lkIGV4dHJhY3RfY2hlY2tfcmVzdWx0KEZJTEUg
KmZwLGRidWYgKmNoZWNrcmVzdWx0X2RidWYpeworCWNoYXIgb3V0cHV0X2J1ZmZlcltNQVhfSU5Q
VVRfQlVGRkVSXT0iIjsKKwljaGFyICp0ZW1wX2J1ZmZlcjsKKworCS8qIGluaXRpYWxpemUgYnVm
ZmVyICovCisJc3RyY3B5KG91dHB1dF9idWZmZXIsIiIpOworCisJLyogZ2V0IGFsbCBsaW5lcyBv
ZiBwbHVnaW4gb3V0cHV0IC0gZXNjYXBlIG5ld2xpbmVzICovCisJd2hpbGUoZmdldHMob3V0cHV0
X2J1ZmZlcixzaXplb2Yob3V0cHV0X2J1ZmZlciktMSxmcCkpeworCQl0ZW1wX2J1ZmZlcj1lc2Nh
cGVfbmV3bGluZXMob3V0cHV0X2J1ZmZlcik7CisJCWRidWZfc3RyY2F0KGNoZWNrcmVzdWx0X2Ri
dWYsdGVtcF9idWZmZXIpOworCQlteV9mcmVlKHRlbXBfYnVmZmVyKTsKKwkJfQorCX0KKworLyog
Y29udmVydCBhIGNvbW1hbmQgbGluZSB0byBhbiBhcnJheSBvZiBhcmd1bWVudHMsIHN1aXRhYmxl
IGZvciBleGVjKiBmdW5jdGlvbnMgKi8KK3N0YXRpYyBpbnQgcGFyc2VfY29tbWFuZF9saW5lKGNo
YXIgKmNtZCwgY2hhciAqYXJndltNQVhfQ01EX0FSR1NdKXsKKwl1bnNpZ25lZCBpbnQgYXJnYz0w
OworCWNoYXIgKnBhcnNlZF9jbWQ7CisKKwkvKiBTa2lwIGluaXRpYWwgd2hpdGUtc3BhY2UgY2hh
cmFjdGVycy4gKi8KKwlmb3IocGFyc2VkX2NtZD1jbWQ7aXNzcGFjZSgqY21kKTsrK2NtZCkKKwkJ
OworCisJLyogUGFyc2UgY29tbWFuZCBsaW5lLiAqLworCXdoaWxlKCpjbWQmJihhcmdjPE1BWF9D
TURfQVJHUy0xKSl7CisJCWFyZ3ZbYXJnYysrXT1wYXJzZWRfY21kOworCQlzd2l0Y2goKmNtZCl7
CisJCWNhc2UgJ1wnJzoKKwkJCXdoaWxlKCgqY21kKSYmKCpjbWQhPSdcJycpKQorCQkJCSoocGFy
c2VkX2NtZCsrKT0qKGNtZCsrKTsKKwkJCWlmKCpjbWQpCisJCQkJKytjbWQ7CisJCQlicmVhazsK
KwkJY2FzZSAnIic6CisJCQl3aGlsZSgoKmNtZCkmJigqY21kIT0nIicpKXsKKwkJCQlpZigoKmNt
ZD09J1xcJykmJmNtZFsxXSYmc3RyY2hyKCJcIlxcXG4iLGNtZFsxXSkpCisJCQkJCSsrY21kOwor
CQkJCSoocGFyc2VkX2NtZCsrKT0qKGNtZCsrKTsKKwkJCQl9CisJCQlpZigqY21kKQorCQkJCSsr
Y21kOworCQkJYnJlYWs7CisJCWRlZmF1bHQ6CisJCQl3aGlsZSgoKmNtZCkmJiFpc3NwYWNlKCpj
bWQpKXsKKwkJCQlpZigoKmNtZD09J1xcJykmJmNtZFsxXSkKKwkJCQkJKytjbWQ7CisJCQkJKihw
YXJzZWRfY21kKyspPSooY21kKyspOworCQkJCX0KKwkJCX0KKwkJd2hpbGUoaXNzcGFjZSgqY21k
KSkKKwkJCSsrY21kOworCQkqKHBhcnNlZF9jbWQrKyk9J1wwJzsKKwkJfQorCWFyZ3ZbYXJnY109
TlVMTDsKKworCXJldHVybiBPSzsKKwl9CisKKy8qIHJ1biBhIGNoZWNrICovCitzdGF0aWMgaW50
IHJ1bl9jaGVjayhjaGFyICpwcm9jZXNzZWRfY29tbWFuZCxkYnVmICpjaGVja3Jlc3VsdF9kYnVm
KXsKKwljaGFyICphcmd2W01BWF9DTURf
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]