Re: [Nagios-devel] [RFC] Flapping-notifications (mis)feature
Posted: Fri Mar 03, 2006 8:48 am
On 3 Mar 2006 at 12:08, Andreas Ericsson wrote:
> A couple of our customers have complained about Nagios sending
> notifications for hosts and services when a host is in scheduled
> downtime. Since scheduled downtime usually means "we're upgrading it
> and then testing the upgrade", this usually means each and every
> service on the machine will be sending a couple of notifications,
> often along with notifications for the host itself.
>
> Going through the source, I see this is the intended behaviour
>
> $ grep -A 12 'SPECIAL CASE FOR FLAPPING' base/notifications.c
>
> to see what I mean. I'm wondering about the usability of this. One
> good solution is to simply remove the "return OK" after the check for
> enabled flapping-notifications. Another, imo less good, is to move the
> entire block of code to below the "normal" case.
>
> I thought I'd better check with people here to see how they feel about
> not getting flapping notifications for hosts and services in scheduled
> downtime before submitting a patch. I'm also a bit unsure if this
> belongs in the 3.x beta branch or if it's to be considered a bugfix
> and thus to be incorporated in the 2.x branch.
>
Thanks for the note. This is indeed a bug. Patches will be posted
to CVS shortly.
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> A couple of our customers have complained about Nagios sending
> notifications for hosts and services when a host is in scheduled
> downtime. Since scheduled downtime usually means "we're upgrading it
> and then testing the upgrade", this usually means each and every
> service on the machine will be sending a couple of notifications,
> often along with notifications for the host itself.
>
> Going through the source, I see this is the intended behaviour
>
> $ grep -A 12 'SPECIAL CASE FOR FLAPPING' base/notifications.c
>
> to see what I mean. I'm wondering about the usability of this. One
> good solution is to simply remove the "return OK" after the check for
> enabled flapping-notifications. Another, imo less good, is to move the
> entire block of code to below the "normal" case.
>
> I thought I'd better check with people here to see how they feel about
> not getting flapping notifications for hosts and services in scheduled
> downtime before submitting a patch. I'm also a bit unsure if this
> belongs in the 3.x beta branch or if it's to be considered a bugfix
> and thus to be incorporated in the 2.x branch.
>
Thanks for the note. This is indeed a bug. Patches will be posted
to CVS shortly.
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]