Re: [Nagios-devel] Minor issues with notification macros/cgi
Posted: Fri Jul 04, 2008 9:25 am
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thomas Guyot-Sionnest wrote:
| I was playing with notifications, and I noted the following two things:
|
| 1. $NOTIFICATIONCOMMENT$ description says that $NOTIFICATIONTYPE$ can be
| ~ 'CUSTOM', however it looks like custom notification are always of type
| PROBLEM or RECOVERY depending on the status of host. IMHO it would be
| clearer to print CUSTOM instead (and update $NOTIFICATIONTYPE$
description).
|
| 2. In notifications.cgi, it shows the notification comment in the
| Information collumn for Acknowledgements, but not for Custom
| notifications (and possibly not for downtime - I haven't tested yet). It
| would make sense to print the comment just like for acknowledgments.
|
| Due to lack of time I can't provide a patch, but I believe it's pretty
| trivial to fix...
I also noted that custom notifications are always sent to pagers. It
would be nice to have an option to toggle that... Ex: if the service is
OK it would be filtered as a recovery...
I believe that would require more work... could also break
backwards-compatibility unfortunately.
- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIblzg6dZ+Kt5BchYRAooWAKDg0qyXo087VsAkTrkVIeyqGQQrFwCg4csa
lEHApKdmQsSJ/X1zFIxRiTY=
=DuXV
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Hash: SHA1
Thomas Guyot-Sionnest wrote:
| I was playing with notifications, and I noted the following two things:
|
| 1. $NOTIFICATIONCOMMENT$ description says that $NOTIFICATIONTYPE$ can be
| ~ 'CUSTOM', however it looks like custom notification are always of type
| PROBLEM or RECOVERY depending on the status of host. IMHO it would be
| clearer to print CUSTOM instead (and update $NOTIFICATIONTYPE$
description).
|
| 2. In notifications.cgi, it shows the notification comment in the
| Information collumn for Acknowledgements, but not for Custom
| notifications (and possibly not for downtime - I haven't tested yet). It
| would make sense to print the comment just like for acknowledgments.
|
| Due to lack of time I can't provide a patch, but I believe it's pretty
| trivial to fix...
I also noted that custom notifications are always sent to pagers. It
would be nice to have an option to toggle that... Ex: if the service is
OK it would be filtered as a recovery...
I believe that would require more work... could also break
backwards-compatibility unfortunately.
- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIblzg6dZ+Kt5BchYRAooWAKDg0qyXo087VsAkTrkVIeyqGQQrFwCg4csa
lEHApKdmQsSJ/X1zFIxRiTY=
=DuXV
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]