Re: [Nagios-devel] Nagios development moving forward
Posted: Thu May 27, 2010 12:51 pm
On 05/27/2010 03:33 PM, Michael Friedrich wrote:
> Hi,
>
> just some feedback from my side on your patches.
>
> -------- Original Message --------
> Subject: [Nagios-devel] Nagios development moving forward
> From: Andreas Ericsson
> To: nagios-devel ,
> [email protected]
> Date: 2010-04-29 20:46
>
>> So for those of you who wish to try out a revamped Nagios with a
>> bunch of bugfixes and code improvements, clone your repo from me
>> or Ton today and build Nagios from source.
>
> I've taken all your commits and applied them manually onto the current
> Icinga Core (we changed things, Nagios did not, and next to that, I'd
> like to understand what you and Toon hacked there
>
Primarily code reduction and simplification. The diffstat between my
dev branch and the upstream master looks like this:
47 files changed, 1563 insertions(+), 4272 deletions(-)
Quite a few bugfixes too ofcourse.
> Your hackings are very very nice, and it's a real good start in fixing
> things and getting rid of old grown code and workarounds.
>
Yup. More can be done so object code only has to be compiled once for
both cgi's and core for quite a small tradeoff in memory usage. This
would mean simpler code and quite a lot simpler build-system, along
with the possibility of installing nagios-devel header files for us
eventmodule hackers.
> This commit is just WOW
>
> http://git.op5.org/git/?p=nagios.git;a= ... 3aa5a0edb9
>
Glad you like it. Macro voodoo is something of a fetish for me.
>
> Regarding taking over commits, kudos have been kept both within commit
> subjects and changelog for our next release including your patches next
> to ours.
>
Thanks. Always nice to be appreciated.
> From the testing arena, everything runs fine. Although the sync
> retention feature is only one half of the good, the other would be
> opsview or some nifty hacking on distributed monitoring Everything
> else resolves as it should be.
>
>
> By chance, get these changes into a revamped tar.gz and hand that to
> packagers, if it does not get into current CVS head. Or at least the
> patch set
>
I'll poke Ethan about releasing 3.2.2 from git so we can get more
people onto the latest and greatest.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> Hi,
>
> just some feedback from my side on your patches.
>
> -------- Original Message --------
> Subject: [Nagios-devel] Nagios development moving forward
> From: Andreas Ericsson
> To: nagios-devel ,
> [email protected]
> Date: 2010-04-29 20:46
>
>> So for those of you who wish to try out a revamped Nagios with a
>> bunch of bugfixes and code improvements, clone your repo from me
>> or Ton today and build Nagios from source.
>
> I've taken all your commits and applied them manually onto the current
> Icinga Core (we changed things, Nagios did not, and next to that, I'd
> like to understand what you and Toon hacked there
>
Primarily code reduction and simplification. The diffstat between my
dev branch and the upstream master looks like this:
47 files changed, 1563 insertions(+), 4272 deletions(-)
Quite a few bugfixes too ofcourse.
> Your hackings are very very nice, and it's a real good start in fixing
> things and getting rid of old grown code and workarounds.
>
Yup. More can be done so object code only has to be compiled once for
both cgi's and core for quite a small tradeoff in memory usage. This
would mean simpler code and quite a lot simpler build-system, along
with the possibility of installing nagios-devel header files for us
eventmodule hackers.
> This commit is just WOW
>
> http://git.op5.org/git/?p=nagios.git;a= ... 3aa5a0edb9
>
Glad you like it. Macro voodoo is something of a fetish for me.
>
> Regarding taking over commits, kudos have been kept both within commit
> subjects and changelog for our next release including your patches next
> to ours.
>
Thanks. Always nice to be appreciated.
> From the testing arena, everything runs fine. Although the sync
> retention feature is only one half of the good, the other would be
> opsview or some nifty hacking on distributed monitoring
Everything> else resolves as it should be.
>
>
> By chance, get these changes into a revamped tar.gz and hand that to
> packagers, if it does not get into current CVS head. Or at least the
> patch set
>
I'll poke Ethan about releasing 3.2.2 from git so we can get more
people onto the latest and greatest.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]