On Tue, 2003-05-20 at 19:37, Karl DeBisschop wrote:
> Let's revisit labels tonight, after I get a chance to look at the
> patches submitted.
I guess I generally don't have a problem with the labels, except I think
there are some typos in check_swap 'user' for 'used'.
I guess I'd like to use 'pct' instead of 'perc' for percent. It seems
much clear to me - is that my own bias or do others agree?
Actually, I'd prefer pct_used, but I suspect that is a personal bias,
and if so, we should grant primacy to the poster.
What I am concerned about is the fact that units of measure are
basically not addressed by the patch. This is of course most important
for check_disk and check_swap. In fact, you can change the output format
of the new check_disk to show its message in any reasonable units --
Bytes through petabytes, IIRC. Changing this setting, however, should
not affect the perf data output, IMHO.
For my part, I lean toward using bytes for both. Even though it may
involve scaling, I think anything else is arbitrary.
As for 1.3.x application, I still feel that 1.3.x should only be getting
bug fixes. That's why I'd prefer this be HEAD only.
> --
> Karl
>
> > Ton
> >
> > > -----Original Message-----
> > > From: SourceForge.net [SMTP:noreply@sourceforge.net]
> > > Sent: Tuesday, May 20, 2003 1:14 PM
> > > To: noreply@sourceforge.net
> > > Subject: [Nagiosplug-devel] [ nagiosplug-Patches-740404 ] 1.3.0
> > > performance addon for disk/http/load/ping/procs/swap/u
> > >
> > > Patches item #740404, was opened at 2003-05-20 12:14
> > > Message generated for change (Tracker Item Submitted) made by Item
> > > Submitter
> > > You can respond by visiting:
> > > https://sourceforge.net/tracker/?func=d ... 404&group_
> > > id=29880
> > >
> > > Category: Perf data
> > > Group: None
> > > Status: Open
> > > Resolution: None
> > > Priority: 5
> > > Submitted By: Edwin Eefting (drpsycho)
> > > Assigned to: Nobody/Anonymous (nobody)
> > > Summary: 1.3.0 performance addon for disk/http/load/ping/procs/swap/u
> > >
> > > Initial Comment:
> > > These contain the new performance patches for 1.3.0.
> > > This way the plugins will return the extra performance data that is
> > > neccesary to make nice graphs with rrd for example. (contact me for the
> > > addons for this)
> > >
> > > developers: please implement this, as i'm seeing people using the most
> > > wicked ways to get performance data now. (e.g. parsing the default plugin
> > > output!)
> > >
> >
> >
> > This private and confidential e-mail has been sent to you by Egg.
> > The Egg group of companies includes Egg Banking plc
> > (registered no. 2999842), Egg Financial Products Ltd (registered
> > no. 3319027) and Egg Investments Ltd (registered no. 3403963) which
> > carries out investment business on behalf of Egg and is regulated
> > by the Financial Services Authority.
> > Registered in England and Wales. Registered offices: 1 Waterhouse Square,
> > 138-142 Holborn, London EC1N 2NA.
> > If you are not the intended recipient of this e-mail and have
> > received it in error, please notify the sender by replying with
> > 'received in error' as the subject and then delete it from your
> > mailbox.
> >
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: ObjectStore.
> > If flattening out C++ or Java code to make your application fit in a
> > relational database is painful, don't do it! Check out ObjectStore.
> > Now part of Progress Software. http://www.objectstore.net/sourceforge
> > _______________________________________________
> > Nagios-devel mailing list
> > Nagios-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/lis ... gios-devel
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: ObjectStore.
> If flattening out C++ or Java code to make your application fit in a
> relational database is painful, don't do it! Check out ObjectStore.
> Now part of Progress Software. http://www.objectstore.net/sourceforge
> __________________________________
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: karl@debisschop.net