Re: [Nagios-devel] [patch] Fix invalid DOM in CGI
Posted: Mon Jan 09, 2012 10:24 am
---159211915-937212516-1326104652=:8432
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Bump!=0A=0A=0A=0A>> =A0 Fr=E5n: Andreas Ericsson =0A>> =A0 Till:=
Sven-G=F6ran Bergh ; Nagios =0A>> Devel=
opers List =0A>> =A0 Kopia: =0A>> =A0 S=
kickat: fredag, 9 december 2011 15:47=0A>> =A0 =C4mne: Re: [Nagios-devel] [=
patch] Fix invalid DOM in CGI=0A>> =0A>> =A0 On 12/09/2011 03:23 PM, Sven-G=
=F6ran Bergh wrote:=0A>>>=0A>>> =A0 Attached patch fixes an invalid DOM.=
=0A>>> =0A>>> =A0 A table element may not have a form=0A>>> =A0 element a=
s a direct child, but the=0A>>> =A0 opposite is OK.=0A>>> =0A>>> =A0 The =
forms become invalid in some browsers=0A>>> =A0 when the CGI:s are AJAX lo=
aded in div=0A>>> =A0 element.=0A>>> =0A>> =0A>> =A0 Neat patch, but why n=
ot start the table directly after the form?=0A> =A0=0A> Because then some i=
nput element will end up directly inside the=0A> table element, and that is=
not valid that either.=0A> =A0=0A>> =A0 That way it would have been obviou=
s that the patch doesn't change=0A>> =A0 the layout. Now it's split so I ca=
n't say for sure that it=0A>> =A0 doesn't without having to look at the cod=
e, and I won't have=0A>> =A0 time to do that until next week. Care to rerol=
l and resend a=0A>> =A0 more easily reviewed patch?=0A> =A0=0A> I think the=
patch is correct as it is, so no
=0A> =A0=0A>> =A0 Thanks.=0A> =A0=0A> =
Thanks=0A> /S-G
---159211915-937212516-1326104652=:8432
Content-Type: application/octet-stream; name="nagios-3.3.1_cgi-DOM-forms.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="nagios-3.3.1_cgi-DOM-forms.patch"
ZGlmZiAtdXJOIG5hZ2lvcy0zLjMuMS5vcmlnL2NnaS9ub3RpZmljYXRpb25z
LmMgbmFnaW9zLTMuMy4xL2NnaS9ub3RpZmljYXRpb25zLmMKLS0tIG5hZ2lv
cy0zLjMuMS5vcmlnL2NnaS9ub3RpZmljYXRpb25zLmMJMjAxMS0wNy0yNiAw
MjoxNjoxMy4wMDAwMDAwMDAgKzAyMDAKKysrIG5hZ2lvcy0zLjMuMS9jZ2kv
bm90aWZpY2F0aW9ucy5jCTIwMTEtMTItMDkgMTQ6NDk6MzYuMDAwMDAwMDAw
ICswMTAwCkBAIC0yMDksNyArMjA5LDYgQEAKIAkJLyogcmlnaHQgaGFuZCBj
b2x1bW4gb2YgdG9wIHJvdyAqLw0KIAkJcHJpbnRmKCI8dGQgYWxpZ249cmln
aHQgdmFsaWduPXRvcCB3aWR0aD0zMyUlPlxuIik7DQogDQotCQlwcmludGYo
Ijx0YWJsZSBib3JkZXI9MCBDTEFTUz0nb3B0Qm94Jz5cbiIpOw0KIAkJcHJp
bnRmKCI8Zm9ybSBtZXRob2Q9J0dFVCcgYWN0aW9uPSclcyc+XG4iLCBOT1RJ
RklDQVRJT05TX0NHSSk7DQogCQlpZihxdWVyeV90eXBlID09IEZJTkRfU0VS
VklDRSkgew0KIAkJCXByaW50ZigiPGlucHV0IHR5cGU9J2hpZGRlbicgbmFt
ZT0naG9zdCcgdmFsdWU9JyVzJz5cbiIsIGVzY2FwZV9zdHJpbmcocXVlcnlf
aG9zdF9uYW1lKSk7DQpAQCAtMjE4LDYgKzIxNyw3IEBACiAJCWVsc2UNCiAJ
CQlwcmludGYoIjxpbnB1dCB0eXBlPSdoaWRkZW4nIG5hbWU9JyVzJyB2YWx1
ZT0nJXMnPlxuIiwgKHF1ZXJ5X3R5cGUgPT0gRklORF9IT1NUKSA/ICJob3N0
IiA6ICJjb250YWN0IiwgKHF1ZXJ5X3R5cGUgPT0gRklORF9IT1NUKSA/IGVz
Y2FwZV9zdHJpbmcocXVlcnlfaG9zdF9uYW1lKSA6IGVzY2FwZV9zdHJpbmco
cXVlcnlfY29udGFjdF9uYW1lKSk7DQogCQlwcmludGYoIjxpbnB1dCB0eXBl
PSdoaWRkZW4nIG5hbWU9J2FyY2hpdmUnIHZhbHVlPSclZCc+XG4iLCBsb2df
YXJjaGl2ZSk7DQorCQlwcmludGYoIjx0YWJsZSBib3JkZXI9MCBDTEFTUz0n
b3B0Qm94Jz5cbiIpOw0KIAkJcHJpbnRmKCI8dHI+XG4iKTsNCiAJCWlmKHF1
ZXJ5X3R5cGUgPT0gRklORF9TRVJWSUNFKQ0KIAkJCXByaW50ZigiPHRkIGFs
aWduPWxlZnQgY29sc3Bhbj0yIENMQVNTPSdvcHRCb3hJdGVtJz5Ob3RpZmlj
YXRpb24gZGV0YWlsIGxldmVsIGZvciB0aGlzIHNlcnZpY2U6PC90ZD4iKTsN
CkBAIC0yNjIsOCArMjYyLDggQEAKIAkJZGlzcGxheV9jb250ZXh0X2hlbHAo
Q09OVEVYVEhFTFBfTk9USUZJQ0FUSU9OUyk7DQogCQlwcmludGYoIjwvdGQ+
PC90cj5cbiIpOw0KIA0KLQkJcHJpbnRmKCI8L2Zvcm0+XG4iKTsNCiAJCXBy
aW50ZigiPC90YWJsZT5cbiIpOw0KKwkJcHJpbnRmKCI8L2Zvcm0+XG4iKTsN
CiANCiAJCXByaW50ZigiPC90ZD5cbiIpOw0KIA0KZGlmZiAtdXJOIG5hZ2lv
cy0zLjMuMS5vcmlnL2NnaS9zaG93bG9nLmMgbmFnaW9zLTMuMy4xL2NnaS9z
aG93bG9nLmMKLS0tIG5hZ2lvcy0zLjMuMS5vcmlnL2NnaS9zaG93bG9nLmMJ
MjAxMS0wNy0yNiAwMjoxNjoxMy4wMDAwMDAwMDAgKzAyMDAKKysrIG5hZ2lv
cy0zLjMuMS9jZ2kvc2hvd2xvZy5jCTIwMTEtMTItMDkgMTQ6NTA6MjMuMDAw
MDAwMDAwICswMTAwCkBAIC0xMjgsOSArMTI4LDkgQEAKIAkJLyogcmlnaHQg
aGFuZCBjb2x1bW4gb2YgdG9wIHJvdyAqLw0KIAkJcHJpbnRmKCI8dGQgYWxp
Z249cmlnaHQgdmFsaWduPXRvcCB3aWR0aD0zMyUlPlxuIik7DQogDQotCQlw
cmludGYoIjx0YWJsZSBib3JkZXI9MCBjZWxsc3BhY2luZz0wIGNlbGxwYWRk
aW5nPTAgQ0xBU1M9J29
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Bump!=0A=0A=0A=0A>> =A0 Fr=E5n: Andreas Ericsson =0A>> =A0 Till:=
Sven-G=F6ran Bergh ; Nagios =0A>> Devel=
opers List =0A>> =A0 Kopia: =0A>> =A0 S=
kickat: fredag, 9 december 2011 15:47=0A>> =A0 =C4mne: Re: [Nagios-devel] [=
patch] Fix invalid DOM in CGI=0A>> =0A>> =A0 On 12/09/2011 03:23 PM, Sven-G=
=F6ran Bergh wrote:=0A>>>=0A>>> =A0 Attached patch fixes an invalid DOM.=
=0A>>> =0A>>> =A0 A table element may not have a form=0A>>> =A0 element a=
s a direct child, but the=0A>>> =A0 opposite is OK.=0A>>> =0A>>> =A0 The =
forms become invalid in some browsers=0A>>> =A0 when the CGI:s are AJAX lo=
aded in div=0A>>> =A0 element.=0A>>> =0A>> =0A>> =A0 Neat patch, but why n=
ot start the table directly after the form?=0A> =A0=0A> Because then some i=
nput element will end up directly inside the=0A> table element, and that is=
not valid that either.=0A> =A0=0A>> =A0 That way it would have been obviou=
s that the patch doesn't change=0A>> =A0 the layout. Now it's split so I ca=
n't say for sure that it=0A>> =A0 doesn't without having to look at the cod=
e, and I won't have=0A>> =A0 time to do that until next week. Care to rerol=
l and resend a=0A>> =A0 more easily reviewed patch?=0A> =A0=0A> I think the=
patch is correct as it is, so no
=0A> =A0=0A>> =A0 Thanks.=0A> =A0=0A> =Thanks=0A> /S-G
---159211915-937212516-1326104652=:8432
Content-Type: application/octet-stream; name="nagios-3.3.1_cgi-DOM-forms.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="nagios-3.3.1_cgi-DOM-forms.patch"
ZGlmZiAtdXJOIG5hZ2lvcy0zLjMuMS5vcmlnL2NnaS9ub3RpZmljYXRpb25z
LmMgbmFnaW9zLTMuMy4xL2NnaS9ub3RpZmljYXRpb25zLmMKLS0tIG5hZ2lv
cy0zLjMuMS5vcmlnL2NnaS9ub3RpZmljYXRpb25zLmMJMjAxMS0wNy0yNiAw
MjoxNjoxMy4wMDAwMDAwMDAgKzAyMDAKKysrIG5hZ2lvcy0zLjMuMS9jZ2kv
bm90aWZpY2F0aW9ucy5jCTIwMTEtMTItMDkgMTQ6NDk6MzYuMDAwMDAwMDAw
ICswMTAwCkBAIC0yMDksNyArMjA5LDYgQEAKIAkJLyogcmlnaHQgaGFuZCBj
b2x1bW4gb2YgdG9wIHJvdyAqLw0KIAkJcHJpbnRmKCI8dGQgYWxpZ249cmln
aHQgdmFsaWduPXRvcCB3aWR0aD0zMyUlPlxuIik7DQogDQotCQlwcmludGYo
Ijx0YWJsZSBib3JkZXI9MCBDTEFTUz0nb3B0Qm94Jz5cbiIpOw0KIAkJcHJp
bnRmKCI8Zm9ybSBtZXRob2Q9J0dFVCcgYWN0aW9uPSclcyc+XG4iLCBOT1RJ
RklDQVRJT05TX0NHSSk7DQogCQlpZihxdWVyeV90eXBlID09IEZJTkRfU0VS
VklDRSkgew0KIAkJCXByaW50ZigiPGlucHV0IHR5cGU9J2hpZGRlbicgbmFt
ZT0naG9zdCcgdmFsdWU9JyVzJz5cbiIsIGVzY2FwZV9zdHJpbmcocXVlcnlf
aG9zdF9uYW1lKSk7DQpAQCAtMjE4LDYgKzIxNyw3IEBACiAJCWVsc2UNCiAJ
CQlwcmludGYoIjxpbnB1dCB0eXBlPSdoaWRkZW4nIG5hbWU9JyVzJyB2YWx1
ZT0nJXMnPlxuIiwgKHF1ZXJ5X3R5cGUgPT0gRklORF9IT1NUKSA/ICJob3N0
IiA6ICJjb250YWN0IiwgKHF1ZXJ5X3R5cGUgPT0gRklORF9IT1NUKSA/IGVz
Y2FwZV9zdHJpbmcocXVlcnlfaG9zdF9uYW1lKSA6IGVzY2FwZV9zdHJpbmco
cXVlcnlfY29udGFjdF9uYW1lKSk7DQogCQlwcmludGYoIjxpbnB1dCB0eXBl
PSdoaWRkZW4nIG5hbWU9J2FyY2hpdmUnIHZhbHVlPSclZCc+XG4iLCBsb2df
YXJjaGl2ZSk7DQorCQlwcmludGYoIjx0YWJsZSBib3JkZXI9MCBDTEFTUz0n
b3B0Qm94Jz5cbiIpOw0KIAkJcHJpbnRmKCI8dHI+XG4iKTsNCiAJCWlmKHF1
ZXJ5X3R5cGUgPT0gRklORF9TRVJWSUNFKQ0KIAkJCXByaW50ZigiPHRkIGFs
aWduPWxlZnQgY29sc3Bhbj0yIENMQVNTPSdvcHRCb3hJdGVtJz5Ob3RpZmlj
YXRpb24gZGV0YWlsIGxldmVsIGZvciB0aGlzIHNlcnZpY2U6PC90ZD4iKTsN
CkBAIC0yNjIsOCArMjYyLDggQEAKIAkJZGlzcGxheV9jb250ZXh0X2hlbHAo
Q09OVEVYVEhFTFBfTk9USUZJQ0FUSU9OUyk7DQogCQlwcmludGYoIjwvdGQ+
PC90cj5cbiIpOw0KIA0KLQkJcHJpbnRmKCI8L2Zvcm0+XG4iKTsNCiAJCXBy
aW50ZigiPC90YWJsZT5cbiIpOw0KKwkJcHJpbnRmKCI8L2Zvcm0+XG4iKTsN
CiANCiAJCXByaW50ZigiPC90ZD5cbiIpOw0KIA0KZGlmZiAtdXJOIG5hZ2lv
cy0zLjMuMS5vcmlnL2NnaS9zaG93bG9nLmMgbmFnaW9zLTMuMy4xL2NnaS9z
aG93bG9nLmMKLS0tIG5hZ2lvcy0zLjMuMS5vcmlnL2NnaS9zaG93bG9nLmMJ
MjAxMS0wNy0yNiAwMjoxNjoxMy4wMDAwMDAwMDAgKzAyMDAKKysrIG5hZ2lv
cy0zLjMuMS9jZ2kvc2hvd2xvZy5jCTIwMTEtMTItMDkgMTQ6NTA6MjMuMDAw
MDAwMDAwICswMTAwCkBAIC0xMjgsOSArMTI4LDkgQEAKIAkJLyogcmlnaHQg
aGFuZCBjb2x1bW4gb2YgdG9wIHJvdyAqLw0KIAkJcHJpbnRmKCI8dGQgYWxp
Z249cmlnaHQgdmFsaWduPXRvcCB3aWR0aD0zMyUlPlxuIik7DQogDQotCQlw
cmludGYoIjx0YWJsZSBib3JkZXI9MCBjZWxsc3BhY2luZz0wIGNlbGxwYWRk
aW5nPTAgQ0xBU1M9J29
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]