Nagios Support Forum

Michael Friedrich wrote:
> Andreas Ericsson wrote:
>> On 11/02/2010 07:23 PM, Vágó Tibor wrote:
>>> Hi Andreas,
>>>
>>> ok, thanks for your information.
>>>
>> I've had a peak. The patch is extremely weirdly indented, making
>> it hard to follow. Spaces are mixed with tabs and the tabsetting
>> seems to be non-standard.
>>
>> Re-indent your parts of the code to either match the current
>> coding standards or to match those used in the linux kernel
>> project and re-submit a new diff. Then I'll have a look again.
> Just a note while working on this - I'd recommend changing
> authorization.cfg into cgiauth.cfg since it's a cgi specific
> implementation and does not relate directly to the core. By not changing
> the name, it might be misleading for users thinking of somewhat core
> authorization somewhere.

call it cgiauth.cfg.in and let it prepare by configure.

if running 'make distclean' having current patch applied, it will rm
*.cfg in sample-config/ and everything is gone

kind regards,
Michael


> Kind regards,
> Michael
>
>> Thanks
>>
>


--
DI (FH) Michael Friedrich

Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria

email: [email protected]
phone: +43 1 4277 14359
fax: +43 1 4277 14279
web: http://www.univie.ac.at/zid

Icinga Core& IDOUtils Developer
http://www.icinga.org






This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]