Re: [Nagios-devel] [patch] Fix invalid DOM in CGI
Posted: Fri Dec 09, 2011 3:19 pm
Sorry forgot to CC list.=0A> Fr=E5n: Andreas Ericsson =0A=0A> =
Till: Sven-G=F6ran Bergh ; Nagios =0A> De=
velopers List =0A> Kopia: =0A> Skicka=
t: fredag, 9 december 2011 15:47=0A> =C4mne: Re: [Nagios-devel] [patch] Fi=
x invalid DOM in CGI=0A> =0A> On 12/09/2011 03:23 PM, Sven-G=F6ran Bergh w=
rote:=0A>> =A0 Attached patch fixes an invalid DOM.=0A>> =0A>> =A0 A table =
element may not have a form=0A>> =A0 element as a direct child, but the=0A>=
> =A0 opposite is OK.=0A>> =0A>> =A0 The forms become invalid in some brows=
ers=0A>> =A0 when the CGI:s are AJAX loaded in div=0A>> =A0 element.=0A>> =
=0A> =0A> Neat patch, but why not start the table directly after the form?=
=0A=A0=0ABecause then some input element will end up directly inside the=0A=
table element, and that is not valid that either.=0A=A0=0A> That way it wo=
uld have been obvious that the patch doesn't change=0A> the layout. Now it=
's split so I can't say for sure that it=0A> doesn't without having to loo=
k at the code, and I won't have=0A> time to do that until next week. Care =
to reroll and resend a=0A> more easily reviewed patch?=0A=A0=0AI think the=
patch is correct as it is, so no
=0A=A0=0A> Thanks.=0A=A0=0AThanks=0A/=
S-G
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Till: Sven-G=F6ran Bergh ; Nagios =0A> De=
velopers List =0A> Kopia: =0A> Skicka=
t: fredag, 9 december 2011 15:47=0A> =C4mne: Re: [Nagios-devel] [patch] Fi=
x invalid DOM in CGI=0A> =0A> On 12/09/2011 03:23 PM, Sven-G=F6ran Bergh w=
rote:=0A>> =A0 Attached patch fixes an invalid DOM.=0A>> =0A>> =A0 A table =
element may not have a form=0A>> =A0 element as a direct child, but the=0A>=
> =A0 opposite is OK.=0A>> =0A>> =A0 The forms become invalid in some brows=
ers=0A>> =A0 when the CGI:s are AJAX loaded in div=0A>> =A0 element.=0A>> =
=0A> =0A> Neat patch, but why not start the table directly after the form?=
=0A=A0=0ABecause then some input element will end up directly inside the=0A=
table element, and that is not valid that either.=0A=A0=0A> That way it wo=
uld have been obvious that the patch doesn't change=0A> the layout. Now it=
's split so I can't say for sure that it=0A> doesn't without having to loo=
k at the code, and I won't have=0A> time to do that until next week. Care =
to reroll and resend a=0A> more easily reviewed patch?=0A=A0=0AI think the=
patch is correct as it is, so no
=0A=A0=0A> Thanks.=0A=A0=0AThanks=0A/=S-G
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]