Re: [Nagios-devel] Event Profiler Patch
Posted: Mon Jun 08, 2009 2:30 pm
Steven D. Morrey wrote:
> I made it a compile time option in my patch for ease of insertion in
> the existing code base. It would be trivial to convert it to a config
> file option. Just add a new option and track it with a global
> variable, then search and replace all of the #ifdef EVENT_PROFILE
> tags with a simple if(gEvent_Profile_Enabled) After that it's just a
> matter of tracking down the unmatched #endif's and that should be it.
> If there is interest in it, I can update the code to do this and
> submit a new patch.
>
That would be preferrable, but please stick to the current style of
naming variables. "event_profiling_enabled" would be an acceptable
variable name.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> I made it a compile time option in my patch for ease of insertion in
> the existing code base. It would be trivial to convert it to a config
> file option. Just add a new option and track it with a global
> variable, then search and replace all of the #ifdef EVENT_PROFILE
> tags with a simple if(gEvent_Profile_Enabled) After that it's just a
> matter of tracking down the unmatched #endif's and that should be it.
> If there is interest in it, I can update the code to do this and
> submit a new patch.
>
That would be preferrable, but please stick to the current style of
naming variables. "event_profiling_enabled" would be an acceptable
variable name.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]