Re: [Nagios-devel] Compiling on OpenBSD
Posted: Thu Aug 11, 2005 2:10 pm
On 11 Aug 2005 at 9:52, Andreas Ericsson wrote:
> Ethan Galstad wrote:
> > Thanks for the note - I'll change the include file ordering. Not
> > sure why you'd still get warnings about WEXITSTATUS and WIFEXITED if
> > there's already a test in there for them, but as long as things
> > compile cleanly, I'll probably leave this as it is for now.
> >
>
> I've noticed this on a couple of occasions myself. The warnings come
> because WEXITSTATUS and WIFEXITED aren't defined in config.h when they
> are parsed there, but there are no conditionals around them in
> sys/wait.h (which is where they actually should be defined). On some
> systems they are duplicated in stdlib.h (FC3 does this, Openwall does
> not). Where they are not, one gets two three-line warnings for every
> C-file compiled. I imagine it can be a bit worrying for those who
> don't know what it means.
>
> The neatest solution is to move the conditional definition of system
> macros to the end of config.h. That way the system headers are
> guaranteed to have the first shot at defining them.
>
Good point. I'll move the definitions to the end of config.h.
Thanks!
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> Ethan Galstad wrote:
> > Thanks for the note - I'll change the include file ordering. Not
> > sure why you'd still get warnings about WEXITSTATUS and WIFEXITED if
> > there's already a test in there for them, but as long as things
> > compile cleanly, I'll probably leave this as it is for now.
> >
>
> I've noticed this on a couple of occasions myself. The warnings come
> because WEXITSTATUS and WIFEXITED aren't defined in config.h when they
> are parsed there, but there are no conditionals around them in
> sys/wait.h (which is where they actually should be defined). On some
> systems they are duplicated in stdlib.h (FC3 does this, Openwall does
> not). Where they are not, one gets two three-line warnings for every
> C-file compiled. I imagine it can be a bit worrying for those who
> don't know what it means.
>
> The neatest solution is to move the conditional definition of system
> macros to the end of config.h. That way the system headers are
> guaranteed to have the first shot at defining them.
>
Good point. I'll move the definitions to the end of config.h.
Thanks!
Ethan Galstad,
Nagios Developer
---
Email: [email protected]
Website: http://www.nagios.org
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]