Re: [Nagios-devel] [patch] Add long_output support to NDOUtils
Posted: Wed Jul 01, 2009 6:19 pm
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
short note on top
Thanks for the work - ndomod.c and the snprintfs %d=3D%s\n are bad to
read, aren't they?
I changed the patch a bit to keep the output/long_output order within
es[] and add the missing free() but long_output support did the way into
CVS.
No more "BUILLD_NAGIOS_3X" either.
Regards,
Hendrik
S=E9bastien Aperghis-Tramoni schrieb:
> Hello,
>=20
>=20
> Attached is a patch I wrote for $work which adds long_output support to
> NDOUtils. We are currently using it in servers soon to be put in
> production, and it currently seems to be working fine. It's against
> Nagios CVS as of a couples of weeks ago. The SQL bit to upgrade an
> existing database is provided in db/mysql-upgrade-long_output.sql. It
> also fixes a small bug that was present in the code (an "#ifdef
> BUILLD_NAGIOS_3X" instead of "#ifdef BUILD_NAGIOS_3X".. two days to fin=
d
> out..)
>=20
> diffstat db/mysql-upgrade-long_output.sql | 18 ++++++++++++++
> db/mysql.sql | 5 ++++
> include/protoapi.h | 1
> src/dbhandlers.c | 48
> ++++++++++++++++++++++++++-------------
> src/ndo2db.c | 1
> src/ndomod.c | 46
> +++++++++++++++++++++++++++++--------
> 6 files changed, 93 insertions(+), 26 deletions(-)
>=20
> Patch attached in plain and gzipped to avoid being mangled.
>=20
>=20
>=20
> Regards
>=20
>=20
> -----------------------------------------------------------------------=
-
>=20
> -----------------------------------------------------------------------=
-------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nev=
ada.
> The future of the web can't happen without you. Join us at MIX09 to he=
lp
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438 ... .visitmix=
.com/
>=20
>=20
> -----------------------------------------------------------------------=
-
>=20
> _______________________________________________
> Nagios-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/lis ... gios-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkpLtrYACgkQlI0PwfxLQjlxzQCfVsmphku3uTup4KKlwFOu+PuZ
PfcAnAhb4BYvfq13o3FnvFZAJuA3Fudi
=3DBXfP
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Hash: SHA1
Hi,
short note on top
Thanks for the work - ndomod.c and the snprintfs %d=3D%s\n are bad to
read, aren't they?
I changed the patch a bit to keep the output/long_output order within
es[] and add the missing free() but long_output support did the way into
CVS.
No more "BUILLD_NAGIOS_3X" either.
Regards,
Hendrik
S=E9bastien Aperghis-Tramoni schrieb:
> Hello,
>=20
>=20
> Attached is a patch I wrote for $work which adds long_output support to
> NDOUtils. We are currently using it in servers soon to be put in
> production, and it currently seems to be working fine. It's against
> Nagios CVS as of a couples of weeks ago. The SQL bit to upgrade an
> existing database is provided in db/mysql-upgrade-long_output.sql. It
> also fixes a small bug that was present in the code (an "#ifdef
> BUILLD_NAGIOS_3X" instead of "#ifdef BUILD_NAGIOS_3X".. two days to fin=
d
> out..)
>=20
> diffstat db/mysql-upgrade-long_output.sql | 18 ++++++++++++++
> db/mysql.sql | 5 ++++
> include/protoapi.h | 1
> src/dbhandlers.c | 48
> ++++++++++++++++++++++++++-------------
> src/ndo2db.c | 1
> src/ndomod.c | 46
> +++++++++++++++++++++++++++++--------
> 6 files changed, 93 insertions(+), 26 deletions(-)
>=20
> Patch attached in plain and gzipped to avoid being mangled.
>=20
>=20
>=20
> Regards
>=20
>=20
> -----------------------------------------------------------------------=
-
>=20
> -----------------------------------------------------------------------=
-------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nev=
ada.
> The future of the web can't happen without you. Join us at MIX09 to he=
lp
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438 ... .visitmix=
.com/
>=20
>=20
> -----------------------------------------------------------------------=
-
>=20
> _______________________________________________
> Nagios-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/lis ... gios-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkpLtrYACgkQlI0PwfxLQjlxzQCfVsmphku3uTup4KKlwFOu+PuZ
PfcAnAhb4BYvfq13o3FnvFZAJuA3Fudi
=3DBXfP
-----END PGP SIGNATURE-----
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]