Re: [Nagios-devel] Nagios 4 on Solaris 10
Posted: Thu Feb 07, 2013 11:04 am
On 02/07/2013 11:08 AM, Ton Voon wrote:
> Guys,
>
> We've managed to fix this issue with the worker threads. It is due to EPOLL not being available on Solaris, so we switch to using SELECT instead. Patch is below (nagios_solaris_uses_select.patch), though it should be detected via configure instead.
>
It can be detected by the compiler. Since epoll() is linux-specific, no other
system will have it. Both poll() and select() are in Posix.1-2001, but select()
is also in the System V spec, so that would be the safest fallthrough.
However, epoll() already shouldn't be used on solaris, due to the ifdef thingie
at the top of lib/iobroker.c, so perhaps it's just the poll() variant of the
i/o broker that's borked.
> We apply various patches to Solaris builds only, some of which look like you've already fixed. The patches we apply are:
> * Adding include/sunos.h and base/sunos.h for missing vasprintf(), asprintf()
These should come from lib/snprintf.h. It seems I've just left it more or
less incomplete.
> * nagios_solaris_rlimit.patch - looks like this is already applied by Andreas
Yup.
> * nagios_solaris_compile_errors_for_comments_h.patch - this is probably incorrectly done but mimics Nagios 3
>
I'll replace it with
typedef struct nagios_comment {
....
} nagios_comment;
#define comment nagios_comment
and do the same for all other types we define in Nagios, while
recommending that people use the "nagios_*" form of the name, as
that's pretty much guaranteed to be "ours" for eternity.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> Guys,
>
> We've managed to fix this issue with the worker threads. It is due to EPOLL not being available on Solaris, so we switch to using SELECT instead. Patch is below (nagios_solaris_uses_select.patch), though it should be detected via configure instead.
>
It can be detected by the compiler. Since epoll() is linux-specific, no other
system will have it. Both poll() and select() are in Posix.1-2001, but select()
is also in the System V spec, so that would be the safest fallthrough.
However, epoll() already shouldn't be used on solaris, due to the ifdef thingie
at the top of lib/iobroker.c, so perhaps it's just the poll() variant of the
i/o broker that's borked.
> We apply various patches to Solaris builds only, some of which look like you've already fixed. The patches we apply are:
> * Adding include/sunos.h and base/sunos.h for missing vasprintf(), asprintf()
These should come from lib/snprintf.h. It seems I've just left it more or
less incomplete.
> * nagios_solaris_rlimit.patch - looks like this is already applied by Andreas
Yup.
> * nagios_solaris_compile_errors_for_comments_h.patch - this is probably incorrectly done but mimics Nagios 3
>
I'll replace it with
typedef struct nagios_comment {
....
} nagios_comment;
#define comment nagios_comment
and do the same for all other types we define in Nagios, while
recommending that people use the "nagios_*" form of the name, as
that's pretty much guaranteed to be "ours" for eternity.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]