Re: [Nagios-devel] Nagios - Attribute based authorization
Posted: Mon Dec 13, 2010 12:16 pm
Hi Andreas,
can U have a look at the new diff?
Kind Regards,
Tibor
2010-11-15 17:52 CET, V=C3=A1g=C3=B3 Tibor wrote:
> 2010-11-15 17:26 keltez=C3=A9ssel, V=C3=A1g=C3=B3 Tibor =C3=ADrta:
>> 2010-11-03 11:43 keltez=C3=A9ssel, Andreas Ericsson =C3=ADrta:
>>> On 11/02/2010 07:23 PM, V=C3=A1g=C3=B3 Tibor wrote:
>>>> Hi Andreas,
>>>>
>>>> ok, thanks for your information.
>>>>
>>>
>>> I've had a peak. The patch is extremely weirdly indented, making
>>> it hard to follow. Spaces are mixed with tabs and the tabsetting
>>> seems to be non-standard.
>>>
>>> Re-indent your parts of the code to either match the current
>>> coding standards or to match those used in the linux kernel
>>> project and re-submit a new diff. Then I'll have a look again.
>>
>> Dear Andreas,
>>
>> here is the reformatted nicely tabbed diff file.
>>
>> In this patch I've changed the authorization filename from
>> "authorization.cfg" to "cgiauth.cfg" too.
>
> Hi,
>
> Sorry, but NIIFI specific attributes was remain in the patch, so I
> resend the stripped and more detailed version of patch.
>
> Thanks,
> Tibor
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
can U have a look at the new diff?
Kind Regards,
Tibor
2010-11-15 17:52 CET, V=C3=A1g=C3=B3 Tibor wrote:
> 2010-11-15 17:26 keltez=C3=A9ssel, V=C3=A1g=C3=B3 Tibor =C3=ADrta:
>> 2010-11-03 11:43 keltez=C3=A9ssel, Andreas Ericsson =C3=ADrta:
>>> On 11/02/2010 07:23 PM, V=C3=A1g=C3=B3 Tibor wrote:
>>>> Hi Andreas,
>>>>
>>>> ok, thanks for your information.
>>>>
>>>
>>> I've had a peak. The patch is extremely weirdly indented, making
>>> it hard to follow. Spaces are mixed with tabs and the tabsetting
>>> seems to be non-standard.
>>>
>>> Re-indent your parts of the code to either match the current
>>> coding standards or to match those used in the linux kernel
>>> project and re-submit a new diff. Then I'll have a look again.
>>
>> Dear Andreas,
>>
>> here is the reformatted nicely tabbed diff file.
>>
>> In this patch I've changed the authorization filename from
>> "authorization.cfg" to "cgiauth.cfg" too.
>
> Hi,
>
> Sorry, but NIIFI specific attributes was remain in the patch, so I
> resend the stripped and more detailed version of patch.
>
> Thanks,
> Tibor
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]