Re: [Nagios-devel] Patch RFC - Nagios 3.2 - permanently remove
Posted: Tue Nov 03, 2009 8:18 am
Am Montag, den 02.11.2009, 23:07 +0100 schrieb Hendrik Baecker:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 30.10.09 16:32, schrieb Max:
> >
> > So I am thinking that we could conditionally perform that additional
> > sleep if use_large_installation_tweaks in nagios.cfg is set to 0
> > instead of just removing the code and submit that as our patch.
> >
> > Thoughts / opinions?
>
> Sounds like the best of both - non hogging for smaller env but more
> performance for biger environments.
> But where to draw the line?
>
> Bring us a patch against latest cvs head and I will test it in my lab.
> Reporting back to the list, of course.
>
> - -
> Hendrik
I would rather remove it completely since it only occurs if a scheduled
check is skipped, that does not happen to often and also there is some
check code run before so it is not really an empty loop then.
Chris
financial.com AG
Munich head office/Hauptsitz M=C3=BCnchen: Maria-Probst-Str. 19 | 80939 M=
=C3=BCnchen | Germany
Frankfurt branch office/Niederlassung Frankfurt: Messeturm | Friedrich-Eber=
t-Anlage 49 | 60327 Frankfurt | Germany
Management board/Vorstand: Dr. Steffen Boehnert | Dr. Alexis Eisenhofer | D=
r. Yann Samson | Matthias Wiederwach
Supervisory board/Aufsichtsrat: Dr. Dr. Ernst zur Linden (chairman/Vorsitze=
nder)
Register court/Handelsregister: Munich =E2=80=93 HRB 128 972 | Sales tax ID=
number/St.Nr.: DE205 370 553
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 30.10.09 16:32, schrieb Max:
> >
> > So I am thinking that we could conditionally perform that additional
> > sleep if use_large_installation_tweaks in nagios.cfg is set to 0
> > instead of just removing the code and submit that as our patch.
> >
> > Thoughts / opinions?
>
> Sounds like the best of both - non hogging for smaller env but more
> performance for biger environments.
> But where to draw the line?
>
> Bring us a patch against latest cvs head and I will test it in my lab.
> Reporting back to the list, of course.
>
> - -
> Hendrik
I would rather remove it completely since it only occurs if a scheduled
check is skipped, that does not happen to often and also there is some
check code run before so it is not really an empty loop then.
Chris
financial.com AG
Munich head office/Hauptsitz M=C3=BCnchen: Maria-Probst-Str. 19 | 80939 M=
=C3=BCnchen | Germany
Frankfurt branch office/Niederlassung Frankfurt: Messeturm | Friedrich-Eber=
t-Anlage 49 | 60327 Frankfurt | Germany
Management board/Vorstand: Dr. Steffen Boehnert | Dr. Alexis Eisenhofer | D=
r. Yann Samson | Matthias Wiederwach
Supervisory board/Aufsichtsrat: Dr. Dr. Ernst zur Linden (chairman/Vorsitze=
nder)
Register court/Handelsregister: Munich =E2=80=93 HRB 128 972 | Sales tax ID=
number/St.Nr.: DE205 370 553
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]