Re: [Nagios-devel] Purpose of use_syslog
Posted: Fri Jun 05, 2009 2:06 pm
Thanks Andreas,
One thing I don't want to do is break existing functionality like that.
I'll see about modifying it to Only, Both or Off any suggestions on the nam=
ing convention?
My first thought was 0,1,2 meaning, off,only and both, repsectively, but if=
we did that then people with existing installs with syslog on, would sudde=
nly have syslog only and there history browsing would break.
Let me know what you think!
Sincerely,
Steve
________________________________________
From: Andreas Ericsson [[email protected]]
Sent: Friday, June 05, 2009 2:47 AM
To: Nagios Developers List
Subject: Re: [Nagios-devel] Purpose of use_syslog
Jon Angliss wrote:
> On Tue, 2 Jun 2009 09:07:48 -0600, "Steven D. Morrey"
> wrote:
>
>> Ahhah! I see the error of my ways.
>> I just needed to look a bit higher up, basically the write_to_syslog is =
being called from both logging functions, and the use_syslog option is chec=
ked only in the write_to_syslog function as a sort of bail out point.
>> That makes sense, but I wanted the option to mean something a little dif=
ferent, so now I've modified the write_to_all_logs and write_to_all_logs_wi=
th_timestamp to check for use_syslog and only write out the regular log fil=
e if use_syslog is false.
>> This way I don't double my logging overhead. Now use_syslog means use_s=
yslog only
>
> This is how I'd expected it to be as well, but not how it actually is.
> Application bug? Or documentation bug? Either way, it's a little
> vauge, and could do with clearing up.
>
I like the current behaviour, but I'd accept a patch to take 'only' or some=
thing
as an argument to "use_syslog" to make the behaviour you're talking about h=
appen.
Do note that history browsing won't work in the CGI's if nagios.log doesn't=
get
written at all, so this option should very, very clearly be marked in such =
a way
that unsuspecting new users don't shoot themselves in the foot. Recreating a
proper nagios.log from the syslog messages is ofcourse possible, but I'd ra=
ther
avoid having to try it if at all possible. Especially given most distributi=
ons
tendency to only keep syslog files around for four weeks before rotating th=
em
into oblivion. Four weeks means users that want availability reports on a m=
onth
or so won't even realize the data they need isn't where it should be before=
it
doesn't exist anymore. Bad Thing(tm) indeed.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Register now for Nordic Meet on Nagios, June 3-4 in Stockholm
http://nordicmeetonnagios.op5.org/
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
---------------------------------------------------------------------------=
---
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Nagios-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/lis ... gios-devel
NOTICE: This email message is for the sole use of the intended recipient(s=
) and may contain confidential and privileged information. Any unauthorized=
review, use, disclosure or distribution is prohibited. If you are not the =
intended recipient, please contact the sender by reply email and destroy al=
l copies of the original message.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: ndreas Ericsson [[email protected]
One thing I don't want to do is break existing functionality like that.
I'll see about modifying it to Only, Both or Off any suggestions on the nam=
ing convention?
My first thought was 0,1,2 meaning, off,only and both, repsectively, but if=
we did that then people with existing installs with syslog on, would sudde=
nly have syslog only and there history browsing would break.
Let me know what you think!
Sincerely,
Steve
________________________________________
From: Andreas Ericsson [[email protected]]
Sent: Friday, June 05, 2009 2:47 AM
To: Nagios Developers List
Subject: Re: [Nagios-devel] Purpose of use_syslog
Jon Angliss wrote:
> On Tue, 2 Jun 2009 09:07:48 -0600, "Steven D. Morrey"
> wrote:
>
>> Ahhah! I see the error of my ways.
>> I just needed to look a bit higher up, basically the write_to_syslog is =
being called from both logging functions, and the use_syslog option is chec=
ked only in the write_to_syslog function as a sort of bail out point.
>> That makes sense, but I wanted the option to mean something a little dif=
ferent, so now I've modified the write_to_all_logs and write_to_all_logs_wi=
th_timestamp to check for use_syslog and only write out the regular log fil=
e if use_syslog is false.
>> This way I don't double my logging overhead. Now use_syslog means use_s=
yslog only
>
> This is how I'd expected it to be as well, but not how it actually is.
> Application bug? Or documentation bug? Either way, it's a little
> vauge, and could do with clearing up.
>
I like the current behaviour, but I'd accept a patch to take 'only' or some=
thing
as an argument to "use_syslog" to make the behaviour you're talking about h=
appen.
Do note that history browsing won't work in the CGI's if nagios.log doesn't=
get
written at all, so this option should very, very clearly be marked in such =
a way
that unsuspecting new users don't shoot themselves in the foot. Recreating a
proper nagios.log from the syslog messages is ofcourse possible, but I'd ra=
ther
avoid having to try it if at all possible. Especially given most distributi=
ons
tendency to only keep syslog files around for four weeks before rotating th=
em
into oblivion. Four weeks means users that want availability reports on a m=
onth
or so won't even realize the data they need isn't where it should be before=
it
doesn't exist anymore. Bad Thing(tm) indeed.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Register now for Nordic Meet on Nagios, June 3-4 in Stockholm
http://nordicmeetonnagios.op5.org/
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
---------------------------------------------------------------------------=
---
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Nagios-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/lis ... gios-devel
NOTICE: This email message is for the sole use of the intended recipient(s=
) and may contain confidential and privileged information. Any unauthorized=
review, use, disclosure or distribution is prohibited. If you are not the =
intended recipient, please contact the sender by reply email and destroy al=
l copies of the original message.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: ndreas Ericsson [[email protected]