Hello,
I observed that nrpe-2.15 and HEAD (15fb2cff as of this post) does not compile if one provides "--disable-ssl" because "complete_SSL_shutdown" has a signature with an SSL type in it. If one guards that method with the same "HAVE_SSL" check, then both of the binaries compile as expected.
Hope this helps,
-- /v\atthew
p.s. what kind of nonsense is a development board that does not accept .patch as an extension for attachments?!
[PATCH] guard complete_SSL_shutdown against disable-ssl
[PATCH] guard complete_SSL_shutdown against disable-ssl
- Attachments
-
- without_ssl.patch.txt
- ifdef guard complete_SSL_shutdown
- (674 Bytes) Downloaded 302 times
Re: [PATCH] guard complete_SSL_shutdown against disable-ssl
I created a pull request: https://github.com/NagiosEnterprises/nrpe/pull/7
Apologies. I will have someone look at it. Additionally, the official repo for nrpe is now on github: https://github.com/NagiosEnterprises/nrpemdaniel wrote: p.s. what kind of nonsense is a development board that does not accept .patch as an extension for attachments?!
Former Nagios employee
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.
Re: [PATCH] guard complete_SSL_shutdown against disable-ssl
.patch and .diff are now permitted file formats.
Former Nagios employee
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.
Re: [PATCH] guard complete_SSL_shutdown against disable-ssl
Thank you for creating the PR; I have a few more suggestions for nrpe that I will submit over there.abrist wrote:I created a pull request: https://github.com/NagiosEnterprises/nrpe/pull/7
Apologies. I will have someone look at it. Additionally, the official repo for nrpe is now on github: https://github.com/NagiosEnterprises/nrpe
Also, please make an update post to the nagios-devel list on SF that indicates the split between this forum and the Github page. I only came here because of that post, and because the files were distributed from SF and the SF git repo is populated, I never would have thought to look on GH.
Re: [PATCH] guard complete_SSL_shutdown against disable-ssl
In addition to the nagios-devel list, it might be exceedingly helpful to update the sticky topic on here that indicates the project code is on Github.abrist wrote:Additionally, the official repo for nrpe is now on github: https://github.com/NagiosEnterprises/nrpe
I can't edit my last post because they disappear into some kind of moderation queue that I can't see.
-
- -fno-stack-protector
- Posts: 4366
- Joined: Mon Nov 19, 2012 12:10 pm
Re: [PATCH] guard complete_SSL_shutdown against disable-ssl
Some good ideas, we will get those changes rolling!
Nagios-Plugins maintainer exclusively, unless you have other C language bugs with open-source nagios projects, then I am happy to help! Please pm or use other communication to alert me to issues as I no longer track the forum.