Page 1 of 1

[PATCH] guard complete_SSL_shutdown against disable-ssl

Posted: Mon May 12, 2014 5:33 pm
by mdaniel
Hello,

I observed that nrpe-2.15 and HEAD (15fb2cff as of this post) does not compile if one provides "--disable-ssl" because "complete_SSL_shutdown" has a signature with an SSL type in it. If one guards that method with the same "HAVE_SSL" check, then both of the binaries compile as expected.

Hope this helps,
-- /v\atthew

p.s. what kind of nonsense is a development board that does not accept .patch as an extension for attachments?!

Re: [PATCH] guard complete_SSL_shutdown against disable-ssl

Posted: Tue May 13, 2014 11:04 am
by abrist
I created a pull request: https://github.com/NagiosEnterprises/nrpe/pull/7
mdaniel wrote: p.s. what kind of nonsense is a development board that does not accept .patch as an extension for attachments?!
Apologies. I will have someone look at it. Additionally, the official repo for nrpe is now on github: https://github.com/NagiosEnterprises/nrpe

Re: [PATCH] guard complete_SSL_shutdown against disable-ssl

Posted: Tue May 13, 2014 12:20 pm
by abrist
.patch and .diff are now permitted file formats.

Re: [PATCH] guard complete_SSL_shutdown against disable-ssl

Posted: Wed May 14, 2014 12:24 am
by mdaniel
abrist wrote:I created a pull request: https://github.com/NagiosEnterprises/nrpe/pull/7
Apologies. I will have someone look at it. Additionally, the official repo for nrpe is now on github: https://github.com/NagiosEnterprises/nrpe
Thank you for creating the PR; I have a few more suggestions for nrpe that I will submit over there.

Also, please make an update post to the nagios-devel list on SF that indicates the split between this forum and the Github page. I only came here because of that post, and because the files were distributed from SF and the SF git repo is populated, I never would have thought to look on GH.

Re: [PATCH] guard complete_SSL_shutdown against disable-ssl

Posted: Wed May 14, 2014 12:27 am
by mdaniel
abrist wrote:Additionally, the official repo for nrpe is now on github: https://github.com/NagiosEnterprises/nrpe
In addition to the nagios-devel list, it might be exceedingly helpful to update the sticky topic on here that indicates the project code is on Github.

I can't edit my last post because they disappear into some kind of moderation queue that I can't see.

Re: [PATCH] guard complete_SSL_shutdown against disable-ssl

Posted: Wed May 14, 2014 11:09 am
by sreinhardt
Some good ideas, we will get those changes rolling!