Page 1 of 1
Who is reviewing github pull requests ?
Posted: Thu Mar 05, 2015 5:37 pm
by nagmoto
Hi there
I am wondering why the simple typo requests are still not processed/reviewd by core developers.
Example:
https://github.com/NagiosEnterprises/na ... l/22/files
Re: Who is reviewing github pull requests ?
Posted: Thu Mar 05, 2015 6:06 pm
by scottwilkerson
We have not made a full release since this request was made.
Re: Who is reviewing github pull requests ?
Posted: Fri Mar 06, 2015 3:06 am
by nagmoto
scottwilkerson wrote:We have not made a full release since this request was made.
Thanks scott for responding my question. I am new comer to Nagios and like to learn more about the development work flow.
But shouldn't the master branch contain all the latest fixes from community developers ?
and fixes got merged into branch 4.1 later when making release for official 4.1.
Re: Who is reviewing github pull requests ?
Posted: Fri Mar 06, 2015 4:09 pm
by scottwilkerson
Honestly, because your pull request contains a promotion to your misspell_fixer, it's not likely to be pulled strait in anyways.
Re: Who is reviewing github pull requests ?
Posted: Sat Mar 07, 2015 6:04 am
by nagmoto
scottwilkerson wrote:Honestly, because your pull request contains a promotion to your misspell_fixer, it's not likely to be pulled strait in anyways.
I am not connected to misspell_fixer in anyway,fist time hear of such open-source tool. I am using this typo pull request as example.
Looking at the changes in typos, I (a beginner) don't see why a direct pull in is not possible, no functional changes.
Thanks for assigning someone to look into the existing pull requests. prompt pull requests interaction will encourage others to become nagios core developers.
Re: Who is reviewing github pull requests ?
Posted: Mon Mar 09, 2015 10:49 am
by abrist
nagmoto wrote:Thanks for assigning someone to look into the existing pull requests. prompt pull requests interaction will encourage others to become nagios core developers.
You are welcome.