Page 1 of 1

Bulk Renaming Tool - Important!

Posted: Thu Mar 30, 2017 2:07 pm
by TBT
So, just learned a lesson the hard way.

1. With the Bulk Renaming tool, submitting an update of 400+ network element names there was an invalid format upon submission. This of course displays the invalid format error but also RESETS THE FORM DATA, causing loss of all form data. I'd strongly suggest building inline validation on fields to avoid this prior to submission. Also, a method to retain values entered if an error is encountered on the form.

2. Additionally, the "remove" icon (trash can) gives the impression that this action will remove the line item from the list of bulk renaming, which is does. However, it also removes it from monitoring within Nagios. The network element gets deleted. This action shouldn't happen in a tool used for name modification, especially without confirmation on remove actions!

Somebody owes me a T-shirt for this! lol

Re: Bulk Renaming Tool - Important!

Posted: Thu Mar 30, 2017 3:46 pm
by cdienger
We'll hold off on the t-shirt for the time being since we need some clarification : ) How exactly are you producing the error? I tested on a 5.4.3 install by changing the hostname and service name to include invalid characters(!@#$%^) and haven't been able to reproduce. Please clarify exactly how you're using the "remove" icon as I haven't been able to reproduce that one either.

Re: Bulk Renaming Tool - Important!

Posted: Fri Mar 31, 2017 8:02 am
by TBT
cdienger wrote:We'll hold off on the t-shirt for the time being since we need some clarification : ) How exactly are you producing the error? I tested on a 5.4.3 install by changing the hostname and service name to include invalid characters(!@#$%^) and haven't been able to reproduce. Please clarify exactly how you're using the "remove" icon as I haven't been able to reproduce that one either.
So I did some more testing with the "remove" button behavior in 5.4.3 and found my network elements perceived as deleted. They're actually inactive, hence why they didn't show-up in any of the views or config directory. My mistake.

I've also tested the bulk rename with 10 network element line items. Using a invalid hostname format of "Testhost (test)", error is produced "Missing use a valid Host Name for Host: Testhost (test)". This is expected.
However, the form data was kept this time. Perhaps resetting of the form data only occurs when trying to modify a larger number of hosts or after a period of time (page times out)?

Looks like I might end up owing YOU a t-shirt. It would still be nice to have some inline validation in the future. :)

Re: Bulk Renaming Tool - Important!

Posted: Fri Mar 31, 2017 9:44 am
by cdienger
Thanks for the update. I'll try to reproduce this playing with the timeouts a bit.

Re: Bulk Renaming Tool - Important!

Posted: Fri Mar 31, 2017 3:26 pm
by cdienger
I haven't had any luck reproducing the behavior with 500+ objects or getting it to timeout. I'd like to close the thread at this point if you're also unable to reproduce.

Re: Bulk Renaming Tool - Important!

Posted: Fri Mar 31, 2017 3:30 pm
by TBT
cdienger wrote:I haven't had any luck reproducing the behavior with 500+ objects or getting it to timeout. I'd like to close the thread at this point if you're also unable to reproduce.
Okay. I'll request to reopen if we encounter an issue on the next mass renaming. Thanks for your time.