Page 1 of 1

Hypermap - pointless check

Posted: Thu Jul 05, 2018 3:30 am
by jacek
Hi,

In hypermap component "index.php" there is this part:

Code: Select all

if (is_authorized_for_all_objects() == false) {
echo gettext("You are not authorized to view all hosts and
services.");
exit();
}
Which is kind of pointless in my opinion, only users that can view all objects are able to use the hypermap and in the same time the Network Status Map doesn't have this limitation.
If You comment out this part from the code, then all users are able to see the hypermap, and (as expected) they only can see things they have access to.
So this kind of makes better sense.

I comment that out after each upgrade, but I think You should consider changing that in the system permanently.

Re: Hypermap - pointless check

Posted: Thu Jul 05, 2018 9:36 am
by tmcdonald
I sent this along to the devs and got a +1 assuming it passes QA. Thanks for the suggestion!

Re: Hypermap - pointless check

Posted: Thu Jul 05, 2018 2:52 pm
by jacek
Cool! :)

Re: Hypermap - pointless check

Posted: Thu Jul 05, 2018 3:04 pm
by tmcdonald
Yep! Sounds like they're on board with it, so I am going to lock this thread up now.