Page 1 of 1

small bug in broker.c

Posted: Fri Sep 27, 2019 5:15 pm
by eponymousalias
In nagios-4.4.5/base/broker.c:

Code: Select all

    535 /* sends contact status updates to broker */
    536 void broker_contact_status(int type, int flags, int attr, contact *cntct, struct timeval *timestamp) {
    537         nebstruct_service_status_data ds;
Line 537 should be this instead:

Code: Select all

    537         nebstruct_contact_status_data ds;

Re: small bug in broker.c

Posted: Mon Sep 30, 2019 9:38 am
by bheden
You're right, we'll get it fixed.

Thanks. I think in the meantime, this shouldn't matter since nebstruct_service_status_struct and nebstruct_contact_status_struct are almost the exact same struct definition - and the handle broker casts to (void*) and then into the appropriate struct. Since they both are aligned identically, this shouldn't be a problem, but hey those are famous last words.

Anyway, thank you!