Nagios 4.0.8: lib/runcmd.c doesn't compile

[jwoods]

In line 590 of lib/runcmd.c, the following statement is trying to assign -1:

Code: Select all

if (asprintf(&env_string, "%s=%s", name, value) = -1) return -1;

It really should read:

Code: Select all

if (asprintf(&env_string, "%s=%s", name, value) == -1) return -1;

[tmcdonald]

Thanks, passed this on to the devs.

[emislivec]

Thanks for the report jwoods!
What OS / compiler are you working with? Can you post or PM your config.log?

Mea culpa on this one. I had undefined HAVE_SETENV to force that code path in earlier development, but obviously not when/after adding in the error checking. I'll fix this and look at forcing the tests to use the !defined(HAVE_SETENV) path as well.

Have you come across any other problems compiling/installing?