global configuration has unusual sequence of actions

This support forum board is for support questions relating to Nagios Log Server, our solution for managing and monitoring critical log data.
Locked
ananke
Posts: 21
Joined: Fri Jun 03, 2016 3:14 pm

global configuration has unusual sequence of actions

Post by ananke »

Under global configuration we have three main actions:

- Save
- Save & Apply
- Verify

That's already different from the documentation at https://assets.nagios.com/downloads/nag ... Inputs.pdf which lists these actions (in order):

- Save
- Verify
- Apply

Here are some issues:

1) Documentation and UI do not match

2) Recommended order is to first save, then to verify. Ideally, one would first verify if syntax is correct, then save. Otherwise, you can easily end up with broken configuration.

3) When one uses 'Save' then there is no option to Apply. There's no single 'Apply' function, and 'Save & Apply' button becomes grayed out.
User avatar
mcapra
Posts: 3739
Joined: Thu May 05, 2016 3:54 pm

Re: global configuration has unusual sequence of actions

Post by mcapra »

I am unsure if this is a bug strictly speaking, but I've filed a bug report for the issue since the behavior is confusing (Internal TASK ID 8937).

You're still able to apply the configuration from the "Apply Configuration" section of the side menu, but including the option to do it from the same screen that you modify/save the configuration on makes more sense in my mind.
Former Nagios employee
https://www.mcapra.com/
ananke
Posts: 21
Joined: Fri Jun 03, 2016 3:14 pm

Re: global configuration has unusual sequence of actions

Post by ananke »

Honestly, I have not noticed the top left link 'Apply configuration' until you pointed it out, thank you. I've been focused on the prominent buttons, that I associate with actions, and I typically assume that the links on the navigation bar would lead me to different sections.

I wonder if there are any plans to streamline the configuration and remove the ambiguity of the config change process. Right now it seems I can easily shoot myself in the foot by saving a broken config without verifying it afterwards, and restarting logstash at some point later. Snapshots seem to be saved only during the 'Apply' phase, but never during the save stage.

Ideally, I'd see the config process as a simple:

A) Adjust filters
B) Validate the syntax
C) Save & Apply in one step, triggering generation of a previous config snapshot.
User avatar
mcapra
Posts: 3739
Joined: Thu May 05, 2016 3:54 pm

Re: global configuration has unusual sequence of actions

Post by mcapra »

ananke wrote: Ideally, I'd see the config process as a simple:

A) Adjust filters
B) Validate the syntax
C) Save & Apply in one step, triggering generation of a previous config snapshot.
I generally agree; The current workflow could be improved. The aforementioned bug report will include everything in this thread :)

Since a bug report was submit, is it alright if we lock this thread?
Former Nagios employee
https://www.mcapra.com/
ananke
Posts: 21
Joined: Fri Jun 03, 2016 3:14 pm

Re: global configuration has unusual sequence of actions

Post by ananke »

mcapra wrote:Since a bug report was submit, is it alright if we lock this thread?
Certainly, thank you for your help.

Cheers!
Locked