5.4.13 -> 5.5.X upgrade fails on check_radius

[dmurrell]

Hi,

I figured this one out last night, on RHEL7.5 (and probably 7.4), if radcli is installed, the compilation step for compiling check_radius fails.

This is in my yum.log to fix it:
Nov 29 21:46:10 Erased: radcli-compat-devel-1.2.9-1.el7.x86_64
Nov 29 21:46:10 Erased: radcli-devel-1.2.9-1.el7.x86_64
Nov 29 21:46:10 Erased: radcli-1.2.9-1.el7.x86_64

Here's the error message for the upgrade:

Code: Select all

/bin/sh ../libtool --tag=CC   --mode=link gcc -DNP_VERSION='"2.2.1"' -g -O2  -L. -o urlize urlize.o libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lpthread -ldl
libtool: link: gcc -DNP_VERSION=\"2.2.1\" -g -O2 -o urlize urlize.o  -L. libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lpthread -ldl
gcc -DLOCALEDIR=\"/usr/local/nagios/share/locale\" -DHAVE_CONFIG_H -I. -I..  -I.. -I../lib -I../gl -I../intl -I/usr/include/ldap  -I/usr/include  -DNP_VERSION='"2.2.1"' -g -O2 -MT check_radius.o -MD -MP -MF .deps/check_radius.Tpo -c -o check_radius.o check_radius.c
check_radius.c:93:1: error: unknown type name 'ENV'
 ENV *env = NULL;
 ^
check_radius.c: In function 'main':
check_radius.c:203:2: error: too few arguments to function 'rc_send_server'
  result = my_rc_send_server (&data, msg);
  ^
In file included from /usr/include/freeradius-client.h:1:0,
                 from check_radius.c:40:
/usr/include/radcli/radcli.h:654:5: note: declared here
 int rc_send_server (rc_handle *rh, SEND_DATA *data, char *msg,
     ^
make[2]: *** [check_radius.o] Error 1
make[2]: Leaving directory `/root/nagiosxi/subcomponents/nagiosplugins/nagios-plugins-2.2.1/plugins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/nagiosxi/subcomponents/nagiosplugins/nagios-plugins-2.2.1'
make: *** [all] Error 2
[root@nagiosxi-clone nagiosxi]#

Here is what I think the root cause is: https://bugs.debian.org/cgi-bin/bugrepo ... =822337#30

My fix was: (plus checking to see that the yum remove didn't remove other packages, which it didn't)

Code: Select all

yum remove radcli*

After removing it, the upgrade completed fine. This does leave me with no check_radius, but better that than a vunerable install.

[npolovenko]

Hi, @dmurrell. Thanks for this info. I will test out this upgrade in the lab and if I come across the same issue I'll file a bug report.