Re: [Nagios-devel] Unable to stop executing checks with 3.2.2

[Guest]

On 17 Sep 2010, at 19:25, Stephen Gran wrote:

> On Fri, Sep 10, 2010 at 02:21:50PM +0100, Ton Voon said:
>> On 10 Sep 2010, at 13:51, Sven Nierlein wrote:
>>
>>>> I changed the max_parallel_service_checks to 2 and svc2 is still
>>>> not
>>>> getting rescheduled.
>>>>
>>>> So can anyone confirm if either the current code:
>>>> * causes breakage or
>>>> * means that the test is now invalid and svc2->next_check should ==
>>>> now
>>>
>>> Ok, then i can confirm that current code breaks disabling active
>>> host/service checks and the
>>> test is still valid.
>>
>> I think this is sufficient to remove the change. Done in CVS now. The
>> test passes on my system now, so will see what the other tinerbox
>> builds say tomorrow.
>
> Hello,
>
> I think the attached patch addresses the problem slightly more
> accurately than the original patch, logic in the attachment. If it's
> unclear or outright wrong, please let me know.
>
> Cheers,

The test_events.c passes with this change. However, it would be best
if a testcase could be written for the problem this is trying to
solve, which fails without the patch and passes with the patch. This
will ensure the problem will continue to get visibility in future.

If you create that testcase, I'd be more than happy to apply.

Ton






This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]